Closed tzunghanjuang closed 3 days ago
We might want to push a new release of malt before merging this PR :) @josh146
@tzunghanjuang This needs an update because we decided against using dynamic_update_slice right?
@dime10 Yes, I am still looking for the alternative.
@dime10 Yes, I am still looking for the alternative.
Only allowing static indices right?
Only allowing static indices right?
Yes
@dime10 I have updated the set_item primitive and tests.
The malt package has been updated btw :) https://pypi.org/project/diastatic-malt/
HI @dime10. What should be the category for PR? (Feature, improvement or bug fix?)
HI @dime10. What should be the category for PR? (Feature, improvement or bug fix?)
Usually we don't triage PRs by what kind they are (although if you really want to you can). Instead, we assign which part of the project the PR is modifying (docs, ci, frontend, compiler, runtime).
The classification (improvement, bug, etc) is usually used for issues.
EDIT: Oh are you referring to the changelog? In that case I think it is an improvement (since it improves the existing feature array assignment feature) :)
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.99%. Comparing base (
93c05e5
) to head (8e48834
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Context: Make
set_item
primitive detectslice
.If yes, useMust be used with https://github.com/PennyLaneAI/diastatic-malt/pull/6.dynamic_update_slice
.Update (2024/07/12): We no longer consider
dynamic_update_slice
as an option since it produces unwanted results if the indices are out-of-range.Description of the Change:
Malt
package has a new implementation forslice(start, stop, step)
. We have to capture such arguments.Possible Drawbacks:
If the length of assignment does not match,jax.lax.dynamic_update_slice
will adjust the starting point.Related GitHub Issues:
516
[sc-60315]