Closed rauletorresc closed 1 month ago
Small suggestions
Potential bug: the Enzyme submodule is also being updated. I think it shouldn't be updated.
I was following the Catalyst release guide, which states that those TODO removals happen after merging RC into main. But in practice, this could be done already when merging. Thanks for the hint!
I was following the Catalyst release guide, which states that those TODO removals happen after merging RC into main.
Ah, if I am wrong, feel free to ignore my suggestions and correct me :sweat_smile: you have more recent context on these items.
Potential bug: the Enzyme submodule is also being updated. I think it shouldn't be updated.
Did you take a look at the Enzyme submodule and why it is being updated? It is already updated in main to the version main should have, so I don't expect Enzyme to change. But if you know something, let me know :)
Small suggestions Potential bug: the Enzyme submodule is also being updated. I think it shouldn't be updated.
I was following the Catalyst release guide, which states that those TODO removals happen after merging RC into main. But in practice, this could be done already when merging. Thanks for the hint!
It should definitely be done before merging to main!
Small suggestions Potential bug: the Enzyme submodule is also being updated. I think it shouldn't be updated.
I was following the Catalyst release guide, which states that those TODO removals happen after merging RC into main. But in practice, this could be done already when merging. Thanks for the hint!
It should definitely be done before merging to main!
I'll update the guide then :)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #915 +/- ## ========================================== - Coverage 99.95% 97.97% -1.98% ========================================== Files 20 71 +51 Lines 4439 10476 +6037 Branches 0 956 +956 ========================================== + Hits 4437 10264 +5827 - Misses 2 169 +167 - Partials 0 43 +43 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.