PennyLaneAI / catalyst

A JIT compiler for hybrid quantum programs in PennyLane
https://docs.pennylane.ai/projects/catalyst
Apache License 2.0
122 stars 27 forks source link

CUDAQ refactoring #926

Open erick-xanadu opened 1 month ago

erick-xanadu commented 1 month ago

Description of the Change: CUDAQ now inherits from the QJIT class

Benefits: Better code.

Possible Drawbacks: None

Related GitHub Issues: Still cannot handle keyword arguments but we assume that once #814 is merged, it should work

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.90%. Comparing base (5fa4b21) to head (b0e30be).

Files Patch % Lines
...t/third_party/cuda/catalyst_to_cuda_interpreter.py 85.00% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #926 +/- ## ========================================== - Coverage 97.93% 97.90% -0.03% ========================================== Files 73 73 Lines 10330 10326 -4 Branches 1170 1172 +2 ========================================== - Hits 10117 10110 -7 - Misses 170 172 +2 - Partials 43 44 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dime10 commented 1 month ago

This makes #602 obsolete?

erick-xanadu commented 1 month ago

@dime10 yes

erick-xanadu commented 1 month ago

Thanks @erick-xanadu, it is a great clean up!

It was all @josh146

Could you confirm that all tests are running fine? Or does it already run on the CI, I don't remember.

They should be running on the CI/CD. Locally they are running and passing. cuda-quantum gets installed at the same time as oqc-qcaas and the tests are triggered if cuda-quantum is found to be installed.

josh146 commented 1 month ago

@erick-xanadu this is super minor, but just checking here to avoid this PR going stale again :)

erick-xanadu commented 1 month ago

@erick-xanadu this is super minor, but just checking here to avoid this PR going stale again :)

Let me fix the state prep and then look into that last TODO :)