Open erick-xanadu opened 1 month ago
Attention: Patch coverage is 89.28571%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 97.90%. Comparing base (
5fa4b21
) to head (b0e30be
).
Files | Patch % | Lines |
---|---|---|
...t/third_party/cuda/catalyst_to_cuda_interpreter.py | 85.00% | 2 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This makes #602 obsolete?
@dime10 yes
Thanks @erick-xanadu, it is a great clean up!
It was all @josh146
Could you confirm that all tests are running fine? Or does it already run on the CI, I don't remember.
They should be running on the CI/CD. Locally they are running and passing. cuda-quantum gets installed at the same time as oqc-qcaas and the tests are triggered if cuda-quantum is found to be installed.
@erick-xanadu this is super minor, but just checking here to avoid this PR going stale again :)
@erick-xanadu this is super minor, but just checking here to avoid this PR going stale again :)
Let me fix the state prep and then look into that last TODO :)
Description of the Change: CUDAQ now inherits from the QJIT class
Benefits: Better code.
Possible Drawbacks: None
Related GitHub Issues: Still cannot handle keyword arguments but we assume that once #814 is merged, it should work