PennyLaneAI / pennylane-cirq

The PennyLane-Cirq plugin integrates Google's Cirq software library with with PennyLane's quantum machine learning capabilities.
https://docs.pennylane.ai/projects/cirq
Apache License 2.0
52 stars 18 forks source link

Fix batch execute with pasqal device #151

Closed albi3ro closed 1 year ago

albi3ro commented 1 year ago

cirq.Circuit no longer has a device argument.

This wasn't caught as the reset method was not being tested for the pasqal device. This PR also adds a test that will execute multiple circuits.

I also started converting control_radius to a float so we can start using cirq.pasqal in the automatic test matrix.

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (692f586) 99.14% compared to head (48f1bbd) 99.43%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #151 +/- ## ========================================== + Coverage 99.14% 99.43% +0.28% ========================================== Files 8 8 Lines 352 352 ========================================== + Hits 349 350 +1 + Misses 3 2 -1 ``` | [Files](https://app.codecov.io/gh/PennyLaneAI/pennylane-cirq/pull/151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PennyLaneAI) | Coverage Δ | | |---|---|---| | [pennylane\_cirq/cirq\_device.py](https://app.codecov.io/gh/PennyLaneAI/pennylane-cirq/pull/151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PennyLaneAI#diff-cGVubnlsYW5lX2NpcnEvY2lycV9kZXZpY2UucHk=) | `100.00% <100.00%> (+1.03%)` | :arrow_up: | | [pennylane\_cirq/pasqal\_device.py](https://app.codecov.io/gh/PennyLaneAI/pennylane-cirq/pull/151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PennyLaneAI#diff-cGVubnlsYW5lX2NpcnEvcGFzcWFsX2RldmljZS5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

albi3ro commented 1 year ago

should we add a test for reset on that device now too?

covered now by testing batch_execute with a batch. Also by putting it in the device test suite.

albi3ro commented 1 year ago

[sc-46688]