Closed vincentmr closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.13%. Comparing base (
c591f46
) to head (201416b
). Report is 84 commits behind head on master.:exclamation: There is a different number of reports uploaded between BASE (c591f46) and HEAD (201416b). Click for more details.
HEAD has 36 uploads less than BASE
| Flag | BASE (c591f46) | HEAD (201416b) | |------|------|------| ||42|6|
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Before submitting
Please complete the following checklist when submitting a PR:
[ ] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the
tests
directory![ ] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running
make docs
.[ ] Ensure that the test suite passes, by running
make test
.[x] Add a new entry to the
.github/CHANGELOG.md
file, summarizing the change, and including a link back to the PR.[ ] Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed line and fill in the pull request template.
Context: @mlxd mentioned that "the use of structured bindings/lambdas when combined with OpenMP often fails to compile with clang due to missing support"
Description of the Change: Replace structured bindings by variables in
GateImplementationsLM.hpp
.Benefits: Compile with Clang & OpenMP.
Possible Drawbacks:
Related GitHub Issues: