PennyLaneAI / pennylane-lightning

The PennyLane-Lightning plugin provides a fast state-vector simulator written in C++ for use with PennyLane
https://docs.pennylane.ai/projects/lightning
Apache License 2.0
92 stars 40 forks source link

Fix structured bindings Clang + OpenMP bug #856

Closed vincentmr closed 3 months ago

vincentmr commented 3 months ago

Before submitting

Please complete the following checklist when submitting a PR:

When all the above are checked, delete everything above the dashed line and fill in the pull request template.


Context: @mlxd mentioned that "the use of structured bindings/lambdas when combined with OpenMP often fails to compile with clang due to missing support"

Description of the Change: Replace structured bindings by variables in GateImplementationsLM.hpp.

Benefits: Compile with Clang & OpenMP.

Possible Drawbacks:

Related GitHub Issues:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.13%. Comparing base (c591f46) to head (201416b). Report is 84 commits behind head on master.

:exclamation: There is a different number of reports uploaded between BASE (c591f46) and HEAD (201416b). Click for more details.

HEAD has 36 uploads less than BASE | Flag | BASE (c591f46) | HEAD (201416b) | |------|------|------| ||42|6|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #856 +/- ## =========================================== - Coverage 98.31% 87.13% -11.18% =========================================== Files 94 70 -24 Lines 16334 11238 -5096 =========================================== - Hits 16058 9792 -6266 - Misses 276 1446 +1170 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.