Closed LuisAlfredoNu closed 2 months ago
Hello. You may have forgotten to update the changelog! Please edit .github/CHANGELOG.md with:
Attention: Patch coverage is 35.72895%
with 313 lines
in your changes missing coverage. Please review.
Project coverage is 61.36%. Comparing base (
db98cbc
) to head (efa3005
). Report is 1 commits behind head on master.
:exclamation: There is a different number of reports uploaded between BASE (db98cbc) and HEAD (efa3005). Click for more details.
HEAD has 45 uploads less than BASE
| Flag | BASE (db98cbc) | HEAD (efa3005) | |------|------|------| ||52|7|
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@LuisAlfredoNu, it looks like you still have problems with the formatting check.
@AmintorDusko All the suggestions are done or commented on. Could you make a second review, please? :smile:
Before submitting
Please complete the following checklist when submitting a PR:
[ ] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the
tests
directory![X] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running
make docs
.[X] Ensure that the test suite passes, by running
make test
.[ ] Add a new entry to the
.github/CHANGELOG.md
file, summarizing the change, and including a link back to the PR.[X] Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed line and fill in the pull request template.
Context: Following the design of *Lightning Qubit uses the New Device API end to end, we can now migrate lightning.kokkos device to the new device API.
Description of the Change: Increase the reusability of the code by creating base classes for Lightning StateVector, Measurements, and AjointJacobian. Create a new device base class for LightningQubit and LightningKokkos.
Benefits: Improve the maintenance and readability of the Python front-end devices for LQ and LK.
Possible Drawbacks:
Related GitHub Issues:
[sc-71783]