Closed LuisAlfredoNu closed 2 months ago
Hello. You may have forgotten to update the changelog! Please edit .github/CHANGELOG.md with:
Attention: Patch coverage is 79.60000%
with 51 lines
in your changes missing coverage. Please review.
Project coverage is 93.55%. Comparing base (
b375dd3
) to head (96728cb
). Report is 2 commits behind head on gpuNewAPI_backend.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@AmintorDusko
Please let us know if these coverage issues are some fluke.
The coverage issues are related to the MPI part which is under development and has not been tested on the current PR. Although, this does not affect the code for a single device. For LK, I do know why CodeCov never catch the coverage of this device. :confused:
Before submitting
Please complete the following checklist when submitting a PR:
[X] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the
tests
directory![X] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running
make docs
.[X] Ensure that the test suite passes, by running
make test
.[ ] Add a new entry to the
.github/CHANGELOG.md
file, summarizing the change, and including a link back to the PR.[X] Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed line and fill in the pull request template.
Context: Migrate LightningGPU to the new device API
Description of the Change: Create the
state_vector
, andmeasurement
class for the new device API to achieve thesimulate
methodBenefits: Integration of LGPU with the new device API
Possible Drawbacks:
Related GitHub Issues:
Freezzed PR :warning: :snowflake:
To make a smooth integration of LightningGPU with the new device API, we set the branch
gpuNewAPI_backend
as the base branch target for future developments related to this big task.The branch
gpuNewAPI_backend
has the mock of all classes and methods necessary for the new API. Also, several tests were disabled withHowever, these tests will unblocked as the implementation progresses.
After all the developments for integrating LightningGPU with the new API have been completed then the PR will be open to merge to
master
[sc-70932]