Closed LuisAlfredoNu closed 2 months ago
Hello. You may have forgotten to update the changelog! Please edit .github/CHANGELOG.md with:
Attention: Patch coverage is 97.36842%
with 1 line
in your changes missing coverage. Please review.
Please upload report for BASE (
gpuNewAPI_backend@fdc3f32
). Learn more about missing BASE report.
Files with missing lines | Patch % | Lines |
---|---|---|
...ylane_lightning/lightning_gpu/_adjoint_jacobian.py | 96.96% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey @LuisAlfredoNu, is this PR ready for review? Apparently, we have several test fails.
Hey @LuisAlfredoNu, is this PR ready for review? Apparently, we have several test fails.
@AmintorDusko
Sorry, I realize that right now it has several errors after the merge of the last commit of simulate
branch :disappointed:. I will fix it and call to review it again. :smile:
Hey @LuisAlfredoNu, is this PR ready for review? Apparently, we have several test fails.
@AmintorDusko Sorry, I realize that right now it has several errors after the merge of the last commit of
simulate
branch 😞. I will fix it and call to review it again. 😄
Thank you, @LuisAlfredoNu!
Before submitting
Please complete the following checklist when submitting a PR:
[X] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the
tests
directory![X] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running
make docs
.[X] Ensure that the test suite passes, by running
make test
.[ ] Add a new entry to the
.github/CHANGELOG.md
file, summarizing the change, and including a link back to the PR.[X] Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed line and fill in the pull request template.
Context: Migrate LightningGPU to the new device API
Description of the Change: Create the
adjoint-jacobian
class for the new device API to achieve thejacobian
andvjp
methodsBenefits: Unlocking the
adjoint-jacobian
capabilities with the new device API for LGPUPossible Drawbacks:
Related GitHub Issues:
Freezzed PR :warning: :snowflake:
To make a smooth integration of LightningGPU with the new device API, we set the branch
gpuNewAPI_backend
as the base branch target for future developments related to this big task.The branch
gpuNewAPI_backend
has the mock of all classes and methods necessary for the new API. Also, several tests were disabled withHowever, these tests will unblocked as the implementation progresses.
After all the developments for integrating LightningGPU with the new API have been completed then the PR will be open to merge to
master
[sc-70936] [sc-70939]