PennyLaneAI / pennylane-lightning

The PennyLane-Lightning plugin provides a fast state-vector simulator written in C++ for use with PennyLane
https://docs.pennylane.ai/projects/lightning
Apache License 2.0
92 stars 40 forks source link

Add (check) full support for sampling in full parity with Lightning. #908

Closed LuisAlfredoNu closed 2 months ago

LuisAlfredoNu commented 2 months ago

Before submitting

Please complete the following checklist when submitting a PR:

When all the above are checked, delete everything above the dashed line and fill in the pull request template.


Context: Migrate LightningGPU to the new device API

Description of the Change: Add all the functionality of the new device API to LGPU.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Freezzed PR :warning: :snowflake:

To make a smooth integration of LightningGPU with the new device API, we set the branch gpuNewAPI_backend as the base branch target for future developments related to this big task.

The branch gpuNewAPI_backend has the mock of all classes and methods necessary for the new API. Also, several tests were disabled with

if device_name == "lightning.gpu":
    pytest.skip("LGPU new API in WIP.  Skipping.",allow_module_level=True)

However, these tests will unblocked as the implementation progresses.

After all the developments for integrating LightningGPU with the new API have been completed then the PR will be open to merge to master

[sc-70946]

github-actions[bot] commented 2 months ago

Hello. You may have forgotten to update the changelog! Please edit .github/CHANGELOG.md with:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 9.63855% with 75 lines in your changes missing coverage. Please review.

Project coverage is 56.16%. Comparing base (a7c4b09) to head (f63a234). Report is 1 commits behind head on gpuNewAPI_backend.

Files with missing lines Patch % Lines
pennylane_lightning/lightning_gpu/lightning_gpu.py 9.63% 75 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (a7c4b09) and HEAD (f63a234). Click for more details.

HEAD has 3 uploads less than BASE | Flag | BASE (a7c4b09) | HEAD (f63a234) | |------|------|------| ||9|6|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## gpuNewAPI_backend #908 +/- ## ====================================================== - Coverage 93.77% 56.16% -37.61% ====================================================== Files 110 28 -82 Lines 13968 2345 -11623 ====================================================== - Hits 13098 1317 -11781 - Misses 870 1028 +158 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.