PennyLaneAI / pennylane-pq

Contains the PennyLane ProjectQ plugin. This plugin provides three devices to work with PennyLane - the ProjectQ IBM device, the ProjectQ quantum simulator, and the ProjectQ classical simulator.
https://docs.pennylane.ai/projects/projectq
Apache License 2.0
16 stars 9 forks source link

pip3 install pennylane_pq fails on osx, dockerhub & ubuntu #52

Closed twobombs closed 5 years ago

twobombs commented 5 years ago
Screenshot 2019-07-17 at 14 42 10

package seems to miss requirements.txt

I could go back to a code build, but the 'pip3 install' is more elegant :)

Saw this happen on OSX and ARM64

co9olguy commented 5 years ago

Thanks @twobombs, we'll have to look into this. Obviously the repo has the requirements.txt, so it's not immediately clear what the discrepancy is here

twobombs commented 5 years ago

typo in packaging ?

Screenshot 2019-07-30 at 10 25 09

Screenshot 2019-07-30 at 10 24 08

twobombs commented 5 years ago

After copy & rename requires.txt to the root of project filename requirement.txt it builds

Screenshot 2019-07-30 at 10 31 31

.... and installs

Screenshot 2019-07-30 at 10 31 57

FYI :)

josh146 commented 5 years ago

Thanks @twobombs! That helped me narrow it down - there was a bug in setup.py, where it was attempting to read and open from requirements.txt (even though it didn't need to). I've now fixed this in #53

twobombs commented 5 years ago

Would it be prudent to make the new release ( 0.50-dev ) avaliable on https://pypi.org/project/PennyLane/ or does this work automatically by some trigger ?

josh146 commented 5 years ago

I might make a quick bugfix release (0.4.1) :)

twobombs commented 5 years ago

Haven't seen a release yet on https://pypi.org/project/PennyLane/#history So technically the bug hasn't been fixed in that the pip3 install now does work.

co9olguy commented 5 years ago

Fair enough @twobombs :) I'll reopen until the update is available via pip

josh146 commented 5 years ago

Hi @twobombs, the v0.4.1 bugfix release is now available on pip :slightly_smiling_face: