PennyLaneAI / pennylane-pq

Contains the PennyLane ProjectQ plugin. This plugin provides three devices to work with PennyLane - the ProjectQ IBM device, the ProjectQ quantum simulator, and the ProjectQ classical simulator.
https://docs.pennylane.ai/projects/projectq
Apache License 2.0
16 stars 9 forks source link

Redesign docs #60

Closed mariaschuld closed 4 years ago

mariaschuld commented 4 years ago

Description of the Change:

Redesign documentation of the plugin to be consistent with others.

Since this is a larger PR, it is recommended to check the docs in a local build.

The PR also includes a minor change in an import statement, to prevent automodapi from documenting imported classes.

mariaschuld commented 4 years ago

The tests are failing on master as well. I added a ticket on that.

I think it is a change in the IBM API? The fails complain about the user keyword argument...

thisac commented 4 years ago

The tests are failing on master as well. I added a ticket on that.

I think it is a change in the IBM API? The fails complain about the user keyword argument...

I noticed that as well. I agree it seems like it could be caused by a change in the IBM API, but I'm not at all familiar with it. I could look into it a bit later, but maybe there's someone else who is more familiar with the API and could solve it quicker. :slightly_smiling_face:

josh146 commented 4 years ago

A couple of months ago, IBM deprecated their original v1 API, for a new v2 API.

mariaschuld commented 4 years ago

We decided that I will open an issue, but we wait for further development from the ProjectQ side.

mariaschuld commented 4 years ago

@josh146 can we merge this besides the failing tests?

josh146 commented 4 years ago

Go for it!