search

PennyLaneAI / pennylane-pq

Contains the PennyLane ProjectQ plugin. This plugin provides three devices to work with PennyLane - the ProjectQ IBM device, the ProjectQ quantum simulator, and the ProjectQ classical simulator.
https://docs.pennylane.ai/projects/projectq
Apache License 2.0
16 stars 9 forks source link

Tests for IBM device failing. #61

Closed mariaschuld closed 3 years ago

mariaschuld commented 4 years ago

Issue description

The tests for the IBM device are currently failing, due to a user argument passed to IBM.

A couple of months ago, IBM deprecated their original v1 API, for a new v2 API, and it is possible that ProjectQ (which is only minimally maintained) did not update their interface accordingly.

Since this is out of the scope of this plugin, we will wait for further changes in ProjectQ.

josh146 commented 4 years ago

It looks like ProjectQ's IBM backend was updated for the v2 API: https://github.com/ProjectQ-Framework/ProjectQ/tree/develop/projectq/backends/_ibm

Can we modify the pinned version of ProjectQ in requirements.txt to the latest version, and see if this fixes the tests?

mariaschuld commented 4 years ago

I'm using the latest version and it fails, but this is no surprise since we are calling the IBM device using the old signature. I'll try to fix that...

mariaschuld commented 3 years ago

This one was long fixed.