Update plugin to natively support Ugate, Pgate, and SXgate

PennyLaneAI / pennylane-qiskit

The PennyLane-Qiskit plugin integrates the Qiskit quantum computing framework and IBM Q with PennyLane.

https://docs.pennylane.ai/projects/qiskit

Apache License 2.0

189 stars 66 forks source link

Update plugin to natively support Ugate, Pgate, and SXgate #113

Open josh146 opened 4 years ago

josh146 commented 4 years ago

The Ugate is the new Qiskit label for the U3gate
The Pgate corresponds to the PennyLane PhaseShift operation
The SXgate (sqrtX gate) is new, and currently does not have a PennyLane native equivalent.
Qiskit has deprecated the [u1, u2, u3] basis in favour of the new [p, sx] basis.

Once the above gates are natively available in PennyLane, we should update the plugin to use the newly available gates.

charmerDark commented 3 years ago

Hey! Is this issue still open? The SXgate is now supported and cant be used in the plugin too right? I understand Ugate and Pgate have already been updated in the v0.23 update.

josh146 commented 3 years ago

Hi @charmerDark, having a look at the Qiskit device's supported operations, https://github.com/PennyLaneAI/pennylane-qiskit/blob/57934622ee0531212e032c6dd24271c5fd1b4d6d/pennylane_qiskit/qiskit_device.py#L36 it appears that SX is not yet listed. Further, ex.PhaseGate and ex.U3Gate currently in used by the plugin might be deprecated by Qiskit and could be in need of an update!

So I would say that this issue is still valid, yes.

charmerDark commented 3 years ago

Hey! Is this issue still open? The SXgate is now supported and cant be used in the plugin too right? I understand Ugate and Pgate have already been updated in the v0.23 update.

I'm sorry..I meant now that SX is available on pennylane, it could be added to the list of supported operations. the 'cant' was a typo :sweat_smile:

josh146 commented 3 years ago

Ah I see, yes definitely @charmerDark!