Closed austingmhuang closed 4 months ago
[sc-63543]
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.76%. Comparing base (
5e11e3a
) to head (ba336fe
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Wrt codecov, it's just upset that initializing the BasicAer
device isn't being tested.
We can wait to merge this until we've merged a PR removing the BasicAer
device, and then re-trigger CI and it should pass. Alternatively, we can have someone with authorization override CodeCov and merge.
We can wait to merge this until we've merged a PR removing the
BasicAer
device, and then re-trigger CI and it should pass. Alternatively, we can have someone with authorization override CodeCov and merge.
I think we can wait and merge this after removing the BasicAer
device. I'll open that PR ASAP.
Looks good! A few small loose ends to wrap up:
- lets also rename
tests_qiskit_1.yml
totests.yml
, since that is the standard name people will be looking for to find the test CI file
Ok yeah, I didn't know that :sweat_smile:
- there are also 0.46 and 1.0 tests run twice a week for the test matrix (the IBMQ tests) - we should similarly delete the 0.46 version and rename the 1.0 version to
ibmq_tests.yml
. Long term those tests might not make sense as we move to local testing with FakeHardware, but for now let's just do that.
Ok, makes sense 👍
- Lets add a comment on the PR for the feature branch targeting master, to remind us to update the Plugin Test Matrix when the branch is eventually merged - removing the IBMQ tests will need to be reflected here (but not until the tests are removed on
master
)
Done.
About the tests being removed, will we be still testing for
0.46
or removing them fully? 🤔
We will be removing them fully. 0.46
and previous versions will no longer be supported.
In October Qiskit will no longer support 0.46 and previous versions accessing the real hardware, so it doesn't make sense for us to support it on the July release just to deprecate it in October.
This new device will no longer support Qiskit <0.46. Therefore testing for those versions is no longer necessary and has been deleted from the CI workflow.