PennyLaneAI / pennylane-qiskit

The PennyLane-Qiskit plugin integrates the Qiskit quantum computing framework and IBM Q with PennyLane.
https://docs.pennylane.ai/projects/qiskit
Apache License 2.0
184 stars 66 forks source link

Update reqs to 1.0 #536

Closed austingmhuang closed 4 months ago

austingmhuang commented 4 months ago

This new device will no longer support Qiskit <0.46. Therefore testing for those versions is no longer necessary and has been deleted from the CI workflow.

austingmhuang commented 4 months ago

[sc-63543]

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.76%. Comparing base (5e11e3a) to head (ba336fe).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## new_device_feature_branch #536 +/- ## ============================================================= - Coverage 100.00% 99.76% -0.24% ============================================================= Files 8 8 Lines 848 848 ============================================================= - Hits 848 846 -2 - Misses 0 2 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lillian542 commented 4 months ago

Wrt codecov, it's just upset that initializing the BasicAer device isn't being tested.

We can wait to merge this until we've merged a PR removing the BasicAer device, and then re-trigger CI and it should pass. Alternatively, we can have someone with authorization override CodeCov and merge.

austingmhuang commented 4 months ago

We can wait to merge this until we've merged a PR removing the BasicAer device, and then re-trigger CI and it should pass. Alternatively, we can have someone with authorization override CodeCov and merge.

I think we can wait and merge this after removing the BasicAer device. I'll open that PR ASAP.

austingmhuang commented 4 months ago

Looks good! A few small loose ends to wrap up:

  1. lets also rename tests_qiskit_1.yml to tests.yml, since that is the standard name people will be looking for to find the test CI file

Ok yeah, I didn't know that :sweat_smile:

  1. there are also 0.46 and 1.0 tests run twice a week for the test matrix (the IBMQ tests) - we should similarly delete the 0.46 version and rename the 1.0 version to ibmq_tests.yml. Long term those tests might not make sense as we move to local testing with FakeHardware, but for now let's just do that.

Ok, makes sense 👍

  1. Lets add a comment on the PR for the feature branch targeting master, to remind us to update the Plugin Test Matrix when the branch is eventually merged - removing the IBMQ tests will need to be reflected here (but not until the tests are removed on master)

Done.

austingmhuang commented 4 months ago

About the tests being removed, will we be still testing for 0.46 or removing them fully? 🤔

We will be removing them fully. 0.46 and previous versions will no longer be supported. In October Qiskit will no longer support 0.46 and previous versions accessing the real hardware, so it doesn't make sense for us to support it on the July release just to deprecate it in October.