search

PennyLaneAI / pennylane-qiskit

The PennyLane-Qiskit plugin integrates the Qiskit quantum computing framework and IBM Q with PennyLane.
https://docs.pennylane.ai/projects/qiskit
Apache License 2.0
194 stars 66 forks source link

add qasm measurement #555

Closed MashAliK closed 5 months ago

MashAliK commented 6 months ago

For https://github.com/PennyLaneAI/pennylane/issues/5646. Updated load_qasm to take optional measurements as an argument and added the ability for it to make mid-circuit measurements. Tests added in tests/test_converter.py.

trbromley commented 5 months ago

Thanks @MashAliK! :star_struck: I've requested reviews from our team.

lillian542 commented 5 months ago

This is looking good, thanks @MashAliK 🎉 There are some failing tests, but I don't think they are related to your PR (most of them definitely aren't). We'll work on getting that updated and get back to you soon, don't worry about it for now.

Don't forget to update the changelog to include the change, and list yourself as a contributor! This should definitely go under "Improvements". As mentioned above, we may also want to include a second entry for it in "Breaking changes" - let's see what people think makes sense.

MashAliK commented 5 months ago

@lillian542 @obliviateandsurrender Thanks for the suggestions! I've made an update to try to resolve these problems.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (530a6af) to head (9405906). Report is 13 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #555 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 7 7 Lines 553 554 +1 ========================================= + Hits 553 554 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.