search

PennyLaneAI / pennylane-qulacs

The PennyLane-Qulacs plugin integrates the Qulacs quantum computing framework with PennyLane's quantum machine learning capabilities.
https://docs.pennylane.ai/projects/qulacs
Apache License 2.0
27 stars 17 forks source link

Add support for `ControlledQubitUnitary` #50

Open Hosseinberg opened 1 year ago

Hosseinberg commented 1 year ago

resolves issue #49. Tests need to be added though.

Hosseinberg commented 1 year ago

added a test

leofang commented 1 year ago

Friendly nudge @isaacdevlugt 🙂

frederikwilde commented 1 year ago

I'm not sure I understand this correctly, but does this leave the control wires in the |0> state? This would make the control operation trivial, no? Maybe it would be good to test this for the |+> state in the control register. What do you think?

Hi @Hosseinberg, I just wanted to check in and hear what you think about this comment? I think if we have a test like this we can merge the PR.