search

PennyLaneAI / pennylane-qulacs

The PennyLane-Qulacs plugin integrates the Qulacs quantum computing framework with PennyLane's quantum machine learning capabilities.
https://docs.pennylane.ai/projects/qulacs
Apache License 2.0
27 stars 16 forks source link

[Proposal] Remove old benchmarks from Readme #56

Closed albi3ro closed 11 months ago

albi3ro commented 1 year ago

This PR proposes to remove the benchmarks from the readme until such time as we have updated benchmarks.

The table is four years old, and the graph is over a year old. We also have no idea what the simulations were run on, other than it is potentially something with 48 available cores.

The benchmarks also provide no information about what was measured. Single expectation value?

If we are to advertise benchmarks for the plugin, they should be maintained routinely, and fully specified.

mlxd commented 1 year ago

No blocker from me. I'll leave @trbromley and another to approve.

trbromley commented 1 year ago

Do we have reason to believe that the benchmark timings are significantly different now versus then?

mlxd commented 11 months ago

Do we have reason to believe that the benchmark timings are significantly different now versus then?

Yes, they are very different.

trbromley commented 11 months ago

Do we have reason to believe that the benchmark timings are significantly different now versus then?

Yes, they are very different.

Are we able to update instead of remove?