Open vincentmr opened 1 week ago
Attention: Patch coverage is 99.34641%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 99.66%. Comparing base (
f430d18
) to head (928783f
). Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
pennylane/devices/qubit/simulate.py | 99.31% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Before submitting
Please complete the following checklist when submitting a PR:
[x] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the test directory!
[x] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running
make docs
.[x] Ensure that the test suite passes, by running
make test
.[x] Add a new entry to the
doc/releases/changelog-dev.md
file, summarizing the change, and including a link back to the PR.[x] The PennyLane source code conforms to PEP8 standards. We check all of our code against Pylint. To lint modified files, simply
pip install pylint
, and then runpylint pennylane/path/to/file.py
.When all the above are checked, delete everything above the dashed line and fill in the pull request template.
Context: The tree-traversal algorithm was first implemented using a recursive approach for simplicity, but this potentially requires very deep stack calls for circuits with a lot of MCMs.
Description of the Change: Implement tree-traversal using an iterative approach. Do basic profiling and optimization.
Benefits: Remove system call increasing the default recursion call limit.
Possible Drawbacks:
Related GitHub Issues: [sc-65241]