Fix failing `test_specs` test cases for legacy opmath

PennyLaneAI / pennylane

PennyLane is a cross-platform Python library for quantum computing, quantum machine learning, and quantum chemistry. Train a quantum computer the same way as a neural network.

https://pennylane.ai

Apache License 2.0

2.17k stars 568 forks source link

Fix failing `test_specs` test cases for legacy opmath #5871

Closed astralcai closed 1 week ago

astralcai commented 1 week ago

Context: Latest failures with legacy opmath: https://github.com/PennyLaneAI/pennylane/actions/runs/9557831967/job/26346373805

Description of the Change:

Replaces qml.X(0) + qml.Y(1) with qml.sum(qml.X(0), qml.Y(1)) because the Sum here does not have data but Hamiltonian does (it treats the two coefficients of 1 and 1 as data), which caused test_int_specs_level to fail at verifying the number of parameters.
Adds a __len__ to the legacy Hamiltonian such that assert len(specs_list) == len(H) in test_splitting_transforms passes correctly.

[sc-66284]

github-actions[bot] commented 1 week ago

Hello. You may have forgotten to update the changelog! Please edit doc/releases/changelog-dev.md with:

A one-to-two sentence description of the change. You may include a small working example for new features.
A link back to this PR.
Your name (or GitHub username) in the contributors section.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.67%. Comparing base (518bcc3) to head (23d8f3c).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #5871 +/- ## ========================================== - Coverage 99.68% 99.67% -0.01% ========================================== Files 421 421 Lines 40464 40170 -294 ========================================== - Hits 40335 40040 -295 - Misses 129 130 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.