PennyLaneAI / pennylane

PennyLane is a cross-platform Python library for quantum computing, quantum machine learning, and quantum chemistry. Train a quantum computer the same way as a neural network.
https://pennylane.ai
Apache License 2.0
2.36k stars 604 forks source link

Change casting rules in various places #6256

Closed mudit2812 closed 2 months ago

mudit2812 commented 2 months ago

Lot's of places cast to float/complex (or don't cast at all when they should). This caused a huge splurge of warnings in many demos in qml (see https://github.com/PennyLaneAI/qml/issues/1212).

Open question: Do we want to do a bug fix release for this PR?

[sc-73429]

github-actions[bot] commented 2 months ago

Hello. You may have forgotten to update the changelog! Please edit doc/releases/changelog-dev.md with:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.63%. Comparing base (5f4169a) to head (84be34f). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6256 +/- ## ========================================== - Coverage 99.63% 99.63% -0.01% ========================================== Files 445 445 Lines 42433 42432 -1 ========================================== - Hits 42278 42277 -1 Misses 155 155 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mudit2812 commented 2 months ago

Looks like all tests are passing, but RTD has been building for an hour. Going to push a [skip ci] commit so tests don't run again, but RTD should still build.

mudit2812 commented 2 months ago

Going to hold off on merging this as we might be cherry picking it into a bug fix release.

mudit2812 commented 2 months ago

Closing in favour of #6260