PennyWieser / Thermobar

Python thermobarometry tool
41 stars 10 forks source link

difficulties adding different error to each sample when only changing one variable #49

Open fboschetty opened 1 month ago

fboschetty commented 1 month ago

I'm attempting to add noise to one variable (H2O_Liq) using tb.add_noise_sample_1phase(). The problem is that I want to add a different error for each sample, rather than a fixed value for all samples as in the examples on read the docs (e.g., 5 rel% or 0.5 wt%) I have tried providing a series, and list, to the variable_err parameter but there is a shape mismatch. Having looked at the code I think implementing this functionality would require a bit of a rewrite, but I wanted to check I wasn't missing something obvious.

Thanks,

Felix

PennyWieser commented 1 month ago

I would use the optoin where you add a dataframe of noise, and just set all the other columns to zero, as that will allow a different value for each value of H2O_Liq