FIX `a bytes-like object is required, not str` in `nxc/protocols/smb.py`

Pennyw0rth / NetExec

The Network Execution Tool

https://netexec.wiki/

BSD 2-Clause "Simplified" License

3.27k stars 358 forks source link

FIX `a bytes-like object is required, not str` in `nxc/protocols/smb.py` #470

Closed Chocapikk closed 4 weeks ago

Chocapikk commented 4 weeks ago

I fixed a bug by moving a portion of the code higher up.

Adamkadaban commented 4 weeks ago

@Chocapikk Does this just fix the crash, or is there an underlying issue? I recently had a problem exactly like this where getServerOS() was returning data that was unpacked incorrectly. Same error, but the underlying issue was in impacket's structs. I'm wondering if this would cause the OS to be misidentified

NeffIsBack commented 4 weeks ago

@Adamkadaban had the same error when accidently scanning myself with responder being active. @Chocapikk can you add a comment in the code explaining why that is needed and when it occured?

Chocapikk commented 4 weeks ago

Hello @NeffIsBack @Adamkadaban , yes this problem occurs when scanning a machine on the network on which Responder is running. The error is triggered when an attempt is made to interact with this system.