feat: FacilityForm component - Githubissues

Pensano-dev / aura-mobile-app

5 stars 0 forks source link

feat: FacilityForm component #31

Closed siqbal181 closed 5 months ago

siqbal181 commented 6 months ago

NB: PR requires npm install as I've got react-native-modal installed

[x] Facility & FacilityForm component created
[x] User is able to select multiple facilities and de-select them
[x] Popup modal appears if user clicks continue button without selecting a facility first
[x] CSS stylings for the button and modal
[x] Placeholder console.log for submission of facilities

siqbal181 commented 5 months ago

Back to draft.. playing around more!

pablisch commented 5 months ago

How is going, Sidra? I noted that the selection resets. Possibly no needed depending on where the state lives but I was wondering if it might be better to keep the selection. I am thinking they might want to add something or take something away but the basic needs are likely to be roughly the same, at least within an app session. Resetting might be a bit annoying. We should also have a reset button.

@pablisch Great points! I've added those and cleaned up the CSS a bit. I made some reusable components (modal and button which we can build props onto). I'm ready for a review :D

pablisch commented 5 months ago

This was the warning I got Screenshot 2024-02-27 at 13 38 20

pablisch commented 5 months ago

Oh, and no conflict expected but please pull main into your branch.

siqbal181 commented 5 months ago

@pablisch Thanks for the comments! have resolved now and noted the npm install required (I'll remember for others!)

Conflicts with main resolved.

RE marrying this up with the DB, I probably will handle this on a separate ticket

pablisch commented 5 months ago

In case you don't see what I see, here is the grey box I mentioned... Screenshot 2024-03-02 at 13 42 10

siqbal181 commented 5 months ago

@pablisch Sorry I stil need to sort the android issue, premature re-review request!

react-native-modal now in package.json too

pablisch commented 5 months ago

Happy to review it and approve it with the tiny Android fix on another ticket. I think visibility and regular integration is much more important than than perfect feature merges. Up to you... let me know either way.

siqbal181 commented 5 months ago

Happy to review it and approve it with the tiny Android fix on another ticket. I think visibility and regular integration is much more important than than perfect feature merges. Up to you... let me know either way.

Agree!!