search

Pensano-dev / aura-mobile-app

5 stars 0 forks source link

Adding MenuBar #68 #81

Closed kikilondon closed 4 months ago

kikilondon commented 4 months ago

68

kikilondon commented 4 months ago

@pablisch I removed react-navigation/native dependency from the package.json root folder and moved to frontend folder.

I don't know anything about husky dependency, maybe there is a specific reason why they installed it there.If not, please let me know, and I will move it to the package.json front-end folder.

pablisch commented 4 months ago

Member

Don't worry about husky. I don't know what it is but it is something Sidra is doing about pre-commit hooks which is all a mystery to me. I imagine it relates to FE and BE so is in the root. I should have been clearer about meaning dependencies as opposed to dev-dependencies.

I see that @react-navigation/native is back in the FE but I also still see it in the root. Since there should be no dependencies there all of the selected code here should go.

Screenshot 2024-03-13 at 12 28 50

If that is not showing on your local branch, check you have pushed everything (I keep forgetting this!) and if it's not that, let me know and we'll sort it.

Everything else looks ready to go.

kikilondon commented 4 months ago

Great ! Finally 🤣🤣

On Fri, 15 Mar 2024 at 19:33, Pablo Joyce @.***> wrote:

@.**** approved this pull request.

Great!

— Reply to this email directly, view it on GitHub https://github.com/Pensano-dev/aura-mobile-app/pull/81#pullrequestreview-1939994964, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZZFRT3JPJBQGXKVEN7O6BLYYM5F7AVCNFSM6AAAAABESZ7IQSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMZZHE4TIOJWGQ . You are receiving this because you authored the thread.Message ID: @.***>