Feat/facilitie component - Githubissues

Pensano-dev / aura-mobile-app

5 stars 0 forks source link

Feat/facilitie component #86

Closed santosluizfelipe closed 3 months ago

santosluizfelipe commented 3 months ago

Added the double tap and long press functionality, changed the background color, added the clear all and next buttons and changed the grid from 3 to 2 icons per row

siqbal181 commented 3 months ago

@santosluizfelipe some merge conflicts to resolve :)

pablisch commented 3 months ago

@santosluizfelipe can we look at this together tomorrow (Tuesday)? There are some names I'd like to work through with you. I completely understand how 'updatedDoubleFacilityList' came about (mostly because I am part of the problem) and what it means, but I think we can make names clearer for anyone looking at this with fresh eyes.

pablisch commented 3 months ago

Hi @santosluizfelipe, I have not fully reviewed this as changes needed may well have a knock-on effect but there are a few manual testing things to sort. Some needed and some useful.

[ ] Reset should clear all selections (currently only clears wanted facilities)
[ ] Continue/Next/Submit should submit when there are only required facilities (currently needs there to be at least one wanted facility)
[ ] Submit should log wanted and required facilities (currently only logs wanted facilities as 'facilities')
[ ] All postman tests fail. These all pass when I run them and they seem to pass in main. Can't see why your branch should make any different to Postman API tests. Just wondered if you had any idea as this is a mystery to me.

pablisch commented 3 months ago

This is also a good time to remove react allergens if we are never using them as they will be there forever otherwise.

santosluizfelipe commented 3 months ago

Hi @santosluizfelipe, I have not fully reviewed this as changes needed may well have a knock-on effect but there are a few manual testing things to sort. Some needed and some useful.

[x] Reset should clear all selections (currently only clears wanted facilities)

[x] Continue/Next/Submit should submit when there are only required facilities (currently needs there to be at least one wanted facility)

[x] Submit should log wanted and required facilities (currently only logs wanted facilities as 'facilities')

[x] All postman tests fail. These all pass when I run them and they seem to pass in main. Can't see why your branch should make any different to Postman API tests. Just wondered if you had any idea as this is a mystery to me.

the postman tests might be because i did not send any data to the backend it is only frontend changes

pablisch commented 3 months ago

the postman tests might be because i did not send any data to the backend it is only frontend changes

They should be totally independent. There was never any requests to the backend. It might be a CI issue but weirdly has so far only happened on this branch so I thought I would ask. We might just have to disable that part of CI until we understand why this is happening.

pablisch commented 3 months ago

I made a branch from your branch, made a PR for it and now the tests pass. NO clue why but that is one step closer.

pablisch commented 3 months ago

Sorry Luiz, I didn't have a chance to look properly but as far as I got, I could see that facilities were able to be in both facility arrays at the same time when each should only appear in one. And really small thing, but could you change the facility log to be wanted facilities to align with the new names.