PentiaLabs / generator-helix

Generate Helix compliant solutions with Yeoman.
MIT License
40 stars 22 forks source link

MSBuild path lookup should work with only VS 2017 installed #109

Open Hafeok opened 6 years ago

Hafeok commented 6 years ago

User story

As a developer, I want to use the generator with only Visualstudio 2017 installed so that i dont need more than one tool installed (Please replace the <> areas and remove this parentheses)

Expected behavior

The generator works with only Visual Studio 2017 installed.

Actual behavior

The generator needs an MSbuild installed from before 2015 in order for the Get-MSBuild path powershell function to return the proper path.

Steps to reproduce the behavior

See issue #107

TakeitEasyAlan commented 5 years ago

I believe we should remove the lookup

TakeitEasyAlan commented 5 years ago

Looking at the usages, we can solve this by simply including Microsoft.Build.dll in the generator module.

107 #118