PentiaLabs / generator-helix

Generate Helix compliant solutions with Yeoman.
MIT License
40 stars 22 forks source link

move module include config files to App_Config/Include/<%=layer%>/<%=… #117

Closed vhil closed 5 years ago

vhil commented 6 years ago

…layerprefixedprojectname%> folder in order to support Sitecore 9 layers ordering on layer folder

Description of the Change

The issue: When having module folders directly inside Include folder, the "Feature" folders are getting loaded before "Foundation" folders, because "e" goes before "o" alphabetically. As long as the number of features/foundations is unknown it is hard to control the order of layer loading.

Resolution: Create parent folders with layer names.

Instead of having structure App_Config

Include -- [Vendor].[Layer].[Module] --- Serialization.config I changed to be App_Config

Include -- [Layer] --- [Vendor].[Layer].[Module] ---- Serialization.config With this structure, you can control the order of custom configuration layer loading in the Layers.config.

Benefits

Control of feature/foundation/project layers load order in layers.config

Possible Drawbacks

Should not impact on anything else really

TakeitEasyAlan commented 6 years ago

Hi,

Wouldn't you still have the issue that the Feature layer folder is loaded before the Foundation layer folder?

vhil commented 6 years ago

If you configure layers then you wont :)

Sent from my iPhone

On 16 Nov 2018, at 10.27, Alan Coates notifications@github.com<mailto:notifications@github.com> wrote:

Hi,

Wouldn't you still have the issue that the Feature layer folder is loaded before the Foundation layer folder?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/PentiaLabs/generator-helix/pull/117#issuecomment-439333728, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFrGiLRWFuBzLp3YFCmXddpyJdwFLLltks5uvoUZgaJpZM4UIhaB.

TakeitEasyAlan commented 5 years ago

can use configure layers as Volodymyr Hil points out