search

People-Places-Solutions / floodmodeller-api

The Flood Modeller Python API is a free and open-source python package which provides a bridge between Flood Modeller and the python programming language to extend the capabilities of Flood Modeller in automated workflows
https://api.floodmodeller.com/api/
Other
38 stars 15 forks source link

Dependencies are not versioned #59

Closed r-gilchrist closed 1 year ago

r-gilchrist commented 1 year ago

Hi,

I used to work as a hydraulic modeller (Mott MacDonald) and am now a software engineer interested in contributing to this project. Although I don't currently use flood modeller professionally, I have done so in the past and have an appreciation of the software/modelling.

I noticed your dependencies have no versions - this is potentially an issue if e.g., there is a major version upgrade that leads to a breaking change.

I am happy to fix this myself and have a local branch with some suggested changes already - but would need to be added as a contributor first so I can submit the PR!

joe-pierce commented 1 year ago

Hi @r-gilchrist,

Thanks for reaching out - we're always interested in having people contribute. I believe you should be able to open pull requests already with default access. You'll just need to fork the repository and open a pull request from there, rather than making changes on a local copy of this repository.

If you already have local changes pointing to this remote repo, you can just create a fork, and set that fork as your remote for you local changes, then push to there and open a pull request 👍

Thank you, Joe

r-gilchrist commented 1 year ago

Thanks @joe-pierce. I've since worked forking out and created https://github.com/People-Places-Solutions/floodmodeller-api/pull/60 👍.

Thanks, Ryan