Config improvements (and also mixin rewrites)

Pepe20129 / difficultytweaker

A Minecraft mod that lets you customize difficulty related stuff.

GNU Lesser General Public License v3.0

7 stars 1 forks source link

Config improvements (and also mixin rewrites) #4

Closed macbrayne closed 3 years ago

macbrayne commented 3 years ago

switched the config format to TOML
refactored some of the mixins:
- reduced impact of WitherSkullEntityMixin
- reduced impact of CaveSpiderEntityMixin
- WIP: try to reduce impact of more mixins (by using more localized mixins)
renamed CommandVars to ModConfig
added save specific settings
removed global settings (except for servers)

macbrayne commented 3 years ago

I also fixed the build not working by switching to 1.17.1 and switching to yarn build 32.

Pepe20129 commented 3 years ago

Thank you. As this is my first mod the code is fairly bad and I appreciate your contributions.

Mincraftr commented 3 years ago

The config seems to get reset (when a client connects after a server restart?).

macbrayne commented 3 years ago

Sorry, my commit title was wrong: it actually doesn't fix the file not being actually created. It was just a fix that, if more options are added, they config file always contains the new options.

Pepe20129 commented 3 years ago

No problem. Also I don't think it's necessary for it to be created automatically, as it's created when needed.

macbrayne commented 3 years ago

If nothing else breaks I think this PR can be merged