search

Pepelux / sippts

Set of tools to audit SIP based VoIP Systems
GNU General Public License v3.0
414 stars 81 forks source link

Hard time packaging sippts #4

Closed noraj closed 5 years ago

noraj commented 5 years ago

We have a hard time packaging sippts for BlackArch. See #2336.

The right packaging standard is to put the app data under /usr/share/sippts/ and then create a wrapper in /usr/bin/sipscan to have the tool available. We packaged it like this in the first place.

As you can see in #2336 the problem is that the script is looking for the database in the working directory. It would be cleaner and easier to package if sippts was using a configuration file (that could stay in /usr/share/sippts/ or in ~/.config/sippts) where the database path is specified. Also system("cp $database_empty $database") if (! -e $database); should be removed so this would be done by the package that would copy the empty db to ~/.config/sippts at installation (users that want to git clone and use the tool independently can still copy the db manually wherever they want).

Pepelux commented 5 years ago

Fixed

Commit: https://github.com/Pepelux/sippts/commit/128520e01f4bfc7ebfacbb5b1d55fa5280787a2c

noraj commented 5 years ago

@Pepelux Thanks, that was very quick.