PepperCode1 / Continuity

A Fabric mod that allows for efficient connected textures
GNU Lesser General Public License v3.0
269 stars 70 forks source link

Better glass pane connected textures by fixing vanilla model issues #301

Open muzikbike opened 1 year ago

muzikbike commented 1 year ago

Currently, glass pane connected textures simply leave the vanilla glass pane model unchanged, and cause every part that uses the glass texture to be connected as a full glass block would. This exaggerates several of the incongruities that exist in vanilla, which is not a desirable outcome. For example, it's common to see edges of panes abruptly ending and seamlessly blending into the background, when you'd expect a border of pixels there. Vertical pillars of single panes also look completely invisible with modern textures, save for the very bottom and top.

With a bit of model reworking and CTM magic, we can get rid of almost all of these issues and achieve a much nicer looking result - we get a border at just about every edge where it'd be expected where previously absent, a massive improvement over what we currently have.

Current CTM appearance: 2023-08-12_20 27 19

Fixed: 2023-08-12_20 27 04

The only things stopping this from being a complete fix are #74 and #295 - if these are addressed, a perfect set of models should be completely achievable.

Here's a downloadable demonstration of the best that can be achieved for panes so far: pane-fix-demo-v1.0.zip

Only normal glass panes in the default textures are fixed by this resource pack - Programmer Art and stained glass panes are completely unaffected. If this idea is approved, I can work on the required textures and models to bring this to all pane colors across both packs.

My idea is that this would be offered with the mod as a third built-in resource pack alongside the current two. Since it redoes the vanilla models, the culling "fix" is present in this pack by default.

rafdelaselva commented 1 year ago

this is great, i would love to be able to use it in my game, hope you continue with the idea, in the meantime will be using your provided .zip instead.

edit: i've tried in my survival and looks pretty good, a lot of the fixes from the texture packs do not work but it looks like is because im playing in 1.18.2 and the texture pack wasnt made for this version, nonetheless, the features that do work look great!, thanks, will definitely keep track of this texture pack, love the fixes it adds