search

PepperCode1 / Continuity

A Fabric mod that allows for efficient connected textures
GNU Lesser General Public License v3.0
275 stars 77 forks source link

Block entity name predicate doesn't work when block entity is loaded with chunk #449

Open skantounis opened 5 months ago

skantounis commented 5 months ago

I have created a custom texture pack that has worked fine with optifine but now shows issues when using it with continuity. In this texturepack I have a .properties files using the fixed method that enables a texture on the minecraft:barrel when the block is renamed. It works when in game but when I close minecraft and reload the world, the texture dissapears and it is the normal minecraft:barrel texture. v1.21 of minecraft on prisim launcher, Release 3.0.0-beta.5+1.21 for continuity, other mods are as followed...

Screenshot 2024-06-26 at 12 22 47 PM
PepperCode1 commented 5 months ago

This has always been an issue. Without quitting, unloading and reloading the chunks that contain the named block entity will also cause this. This happens because the client only receives the block entity name when the block entity is first created; if it is sent as part of a chunk, the name is not sent, so Continuity sees that the block entity does not have a custom name. As such, this is more of a vanilla limitation than a Continuity bug, but I plan to fix it by making a separate mod that will be included (JiJed) in Continuity but can also be installed separately on dedicated servers so clients can receive the custom name. Such a mod already exists, but it is only updated to 1.20.1.

skantounis commented 5 months ago

Thank you so much for the follow up. I will look into this

PepperCode1 commented 5 months ago

This issue should be left open since as I said I plan to fix it within Continuity to the best of my ability. I will close it once that is done.