search

PepperDash / Essentials

The Essentials Application Framework Libraries
MIT License
133 stars 77 forks source link

[FEATURE]-Add console command to report system device health #1058

Open ndorin opened 1 year ago

ndorin commented 1 year ago

Is your feature request related to a problem? Please describe. Currently there is no easy was via console to report the connectivity health of devices in a system that implement ICommunicationMonitor

Describe the solution you'd like Add a console command with corresponding formatted CrestronConsoleResponse that outputs the status of any devices that implement ICommunicationMonitor. Ensure the the output is easily machine parsable.

Describe alternatives you've considered An HTTP request to deliver the same information (future)

@jgutenplan should be consulted on necessary data and preferred format for parsing via UDM lambda

andrew-welker commented 1 year ago

This command already exists: DEVCOMMSTATUS. However, it could be improved, as it is most likely NOT using CrestronConsole.ConsoleCommandResponse, and the output seems to be the type of the class, not a device key, and has some line-ending issues on 3-series.

image image

TrevorPayne commented 1 year ago

I think the line ending issues are just going to be problematic, period. 3-series vs 4-series line endings aren't properly accounted for in Toolbox still and it makes for really ugly console output across the board, unfortunately.