PepperDash / Essentials

The Essentials Application Framework Libraries
MIT License
133 stars 77 forks source link

[FEATURE]-Consider different solutions for language localization support #1064

Open jtalborough opened 1 year ago

jtalborough commented 1 year ago

Additional context Per a chat and request from @ediablo80 & @TrevorPayne it would be great to add better support for multiple languages similar to other private solutions we have including the l18n module.

this issue is opened as a flag and to further the discussion.

One concept that came up was the possibility of using variables in the config that can be filled at runtime with the language support device.

TrevorPayne commented 1 year ago

I'm not certain that we really need to do anything to this other than perhaps integrate the I18N plugin into base essentials.

All it's doing is loading up a JSON (or several), firing an event as the language changes, and allowing an interface for other classes to grab data, by key, from the JObject loaded from the language file.

I think adding this to base essentials and providing some more explicit documentation for how to implement it in code would go a long way to alleviating the perceived deficiency in this code. I can say from experience that it works very well in it's current state. It just requires a bit of tribal knowledge to access.