search

PepperDash / Essentials

The Essentials Application Framework Libraries
MIT License
133 stars 77 forks source link

[BUG]-Cisco Spark Codec doesn't bridge 'Directory Search Busy FB' #950

Open ngenovese11 opened 2 years ago

ngenovese11 commented 2 years ago

Was this bug identified in a specific build version? 1.10.1

Describe the bug No feedback comes through on Digital Join 100 - 'Directory Search Busy FB'

Expected behavior Digital Join 100 to go high while a search is busy

ndorin commented 2 years ago

Investigation revealed that DirectorySearchBusy in VideoCodecControllerJoinMap is not referenced anywhere.

To resolve, I would suggest adding a BoolFeedback to the IHasDirectory interface called SearchInProgressFB or similar. This would then necessitate implementation on CiscoSparkCodec and ZoomRoom likely by setting the FB value high when the SearchDirectory method is called and then low when the DirectoryResultReturned event fires.

There's probably some other ways to tackle it, but that's what first comes to mind.

ndorin commented 2 years ago

This matters most on the CiscoSparkCodec class since it actually uses the codec API to perform a search using on the device. With ZoomRoom we get the entire phonebook when we initially sync with the device and the searching happens in local memory, which is pretty fast.