search

PepperDash / Essentials

The Essentials Application Framework Libraries
MIT License
133 stars 77 forks source link

[BUG]-Dev branch includes change to IBasicVolumeWithFeedback #955

Closed jtalborough closed 1 year ago

jtalborough commented 2 years ago

Was this bug identified in a specific build version? At some point there was a change to the PepperDash.Essentials.Core.IBasicVolumeWithFeedback interface that is included in Dev. I believe the pull request #916 is the issue. When using the Dev branch devices using IBasicVolumeWithFeedback will fail. release 1.10.1 seems to be fine. 

ERROR: Device DspBridge PostActivation failure: Method not found: get_MuteFeedback PepperDash.Essentials.Core.IBasicVolumeWithFeedback
andrew-welker commented 2 years ago

What device was throwing this error?

jtalborough commented 2 years ago

Its was the Qsc Plugin.

On Jun 13, 2022, at 3:22 PM, Andrew Welker @.***> wrote:

What device was throwing this error?

— Reply to this email directly, view it on GitHub https://github.com/PepperDash/Essentials/issues/955#issuecomment-1154391313, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY7PIJDLEPTMFVQJWIYHADVO6KBDANCNFSM5YU6W32A. You are receiving this because you authored the thread.

TrevorPayne commented 1 year ago

@jtalborough

This seems to be resolved - can we close it?