search

PepperDash / Essentials

The Essentials Application Framework Libraries
MIT License
133 stars 77 forks source link

[BUG]-SubpageRefernceList Get__OutputSig returns wrong type #958

Closed Rodney-Driscoll closed 2 years ago

Rodney-Driscoll commented 2 years ago

Was this bug identified in a specific build version? Current repo main branch

Describe the bug

PepperDash.Essentials.Core.SubpageRefernceList.GetUShortOutputSig line 147 current: return SRL.UShortOutput.FirstOrDefault(s => s.Name.Equals(GetBoolFeedbackSigName(index, sigNum))); should be: return SRL.UShortOutput.FirstOrDefault(s => s.Name.Equals(GetUShortOutputSigName(index, sigNum)));

PepperDash.Essentials.Core.SubpageRefernceList.GetStringOutputSig line 162 current: return SRL.StringOutput.FirstOrDefault(s => s.Name.Equals(GetBoolFeedbackSigName(index, sigNum))); should be: return SRL.StringOutput.FirstOrDefault(s => s.Name.Equals(GetStringOutputSigName(index, sigNum)));

Rodney-Driscoll commented 2 years ago

Created PR https://github.com/PepperDash/Essentials/pull/959