search

PepperDash / epi-biamp-tesira

Plugin for controlling Biamp Tesira DSPs from within Essentials.
0 stars 2 forks source link

fix: all commands go through the queue #101

Closed andrew-welker closed 5 months ago

andrew-welker commented 7 months ago

There were some instances where any command that responded with a +OK and not a value bypassed the command queue. This caused issues, as the subsequent GET command to update feedback for a router output WAS enqueued, and responses from subsequent SET responses were stepping on the +OK 0 responses to the GET commands. This is especially apparent on RS-232 connections, and probably doesn't present as an issue for SSH connections.

fixes #89

cdenig commented 5 months ago

[X] Updates tested on multiple systems. [X] Setting multiple switcher/router outputs to 0 at same time no longer causes multi-threaded command/response issues. All commands are queue. Switching between fader, preset, and router commands does not cause issue. Responses remain quick; imperceptible time delays from end user standpoint. When debugging, can see commands enqueue and pop off.
NOTE: no dialers present in test system.

cdenig commented 5 months ago

accidental close. OK to merge.