search

PepperDash / epi-biamp-tesira

Plugin for controlling Biamp Tesira DSPs from within Essentials.
1 stars 2 forks source link

[BUG]- v2.5.x - Fader Up/Down controls cause errors when attempt to goto level outside valid range #106

Open cdenig opened 7 months ago

cdenig commented 7 months ago

Describe the bug Fader Up/Down controls attempt to set Level to value outside maximum/minimum range. and cause invalid parameter errors.

Stacktrace Include a stack trace of the exception if possible.

[dsp01-ssh] Received: '"A_VTCRX_VOL" increment level 2 2.0[0D][0A]
-ERR INVALID_PARAMETER Value out of range: attr:level min:-45 max:3 val:5 -ERR INVALID_PARAMETER[0D][0A]'

To Reproduce Steps to reproduce the behavior:

  1. Assuming stepsize set to 2dB, lower fader to within 2dB of minimum value (or raise fader fader within 2dB of maximum value)
  2. Click on Down (or Up) button
  3. See error in Biamp response of value does not change. Also results in a fader bar not able to goto 0% or 100%.

Expected behavior Up/Down Buttons check if current level is within stepsize and if yes, then send the min or max value on button press.

Screenshots na

Additional context na

cdenig commented 7 months ago

Added logic to prevent sending Volume[Up,Down] commands that would cause fader to move outside valid minMax range.

Added feat so slider will automatically go to [Min,Max]Level if user level request is within IncrementAmount of desired level.

Commit: https://github.com/PepperDash/epi-biamp-tesira/commit/3a5b45baebabb271ec62eb11df0a80d8a5e8dca9

cdenig commented 5 months ago

109 PR submitted. Issue can close on approval