PepperDash / epi-biamp-tesira

Plugin for controlling Biamp Tesira DSPs from within Essentials.
0 stars 2 forks source link

[BUG]-Implementation of more than 25 source selectors overlaps with fader controls #65

Closed jkdevito closed 1 year ago

jkdevito commented 2 years ago

Describe the bug When implementing more than 25 source selectors (an-151-200), the controls will overlap with the fader controls (an-201-400).

Stacktrace

Include a stack trace of the exception if possible.

[12:43:53.141]App 1:[dspBridge-1] EiscApiAdvanced change: UShort 201=869
[12:43:53.142]App 1:[dsp-1] TX: 'switcher26 set sourceSelection 869'
[12:43:53.217]App 1:[dspBridge-1] EiscApiAdvanced change: UShort 201=1862
[12:43:53.218]App 1:[dsp-1] TX: 'switcher26 set sourceSelection 1862'
[12:43:53.281]App 1:[dspBridge-1] EiscApiAdvanced change: UShort 201=2855
[12:43:53.282]App 1:[dsp-1] TX: 'switcher26 set sourceSelection 2855'
[12:43:55.554]App 1:[dspBridge-1] EiscApiAdvanced change: UShort 202=0
[12:43:55.622]App 1:[dspBridge-1] EiscApiAdvanced change: UShort 202=2358
[12:43:55.622]App 1:[dsp-1--LevelControl02] volume: 2358
[12:43:55.622]App 1:[dsp-1] TX: 'FLOOR30LEVEL set level 2 0.000000'
[12:43:55.709]App 1:[dspBridge-1] EiscApiAdvanced change: UShort 202=5834
[12:43:55.709]App 1:[dsp-1--LevelControl02] volume: 5834
[12:43:55.710]App 1:[dsp-1] TX: 'FLOOR30LEVEL set level 2 0.000000'
[12:43:55.772]App 1:[dspBridge-1] EiscApiAdvanced change: UShort 202=7820
[12:43:55.772]App 1:[dsp-1--LevelControl02] volume: 7820
[12:43:55.773]App 1:[dsp-1] TX: 'FLOOR30LEVEL set level 2 0.000000'
[12:43:57.447]App 1:[dspBridge-1] EiscApiAdvanced change: UShort 203=11915
[12:43:57.448]App 1:[dsp-1] TX: 'switcher27 set sourceSelection 11915'
[12:43:57.511]App 1:[dspBridge-1] EiscApiAdvanced change: UShort 203=1862
[12:43:57.512]App 1:[dsp-1] TX: 'switcher27 set sourceSelection 1862'
[12:43:57.587]App 1:[dspBridge-1] EiscApiAdvanced change: UShort 203=3227
[12:43:57.587]App 1:[dsp-1] TX: 'switcher27 set sourceSelection 3227'
[12:43:57.649]App 1:[dspBridge-1] EiscApiAdvanced change: UShort 203=4717
[12:43:57.650]App 1:[dsp-1] TX: 'switcher27 set sourceSelection 4717'
[12:44:00.221]App 1:[dspBridge-1] EiscApiAdvanced change: UShort 204=5213
[12:44:00.221]App 1:[dsp-1--LevelControl04] volume: 5213
[12:44:00.221]App 1:[dsp-1] TX: 'FLOOR30LEVEL set level 4 0.000000'
[12:44:00.280]App 1:[dspBridge-1] EiscApiAdvanced change: UShort 204=3475
[12:44:00.281]App 1:[dsp-1--LevelControl04] volume: 3475
[12:44:00.281]App 1:[dsp-1] TX: 'FLOOR30LEVEL set level 4 0.000000'
[12:44:00.341]App 1:[dspBridge-1] EiscApiAdvanced change: UShort 204=6951
[12:44:00.341]App 1:[dsp-1--LevelControl04] volume: 6951
[12:44:00.342]App 1:[dsp-1] TX: 'FLOOR30LEVEL set level 4 0.000000'
[12:44:00.418]App 1:[dspBridge-1] EiscApiAdvanced change: UShort 204=8192
[12:44:00.418]App 1:[dsp-1--LevelControl04] volume: 8192
[12:44:00.418]App 1:[dsp-1] TX: 'FLOOR30LEVEL set level 4 0.000000'

To Reproduce Steps to reproduce the behavior:

  1. Configure DSP to implement 26+ source selectors
  2. Manipulate Fader1, 3, 5... controls
  3. Switcher will be controlled in place of the fader

Expected behavior Switcher joins should not overlap fader controls

jkdevito commented 2 years ago

When modifying the configuration to instantiate source selectors in standalone bridge mode, the issue is still present.

jtalborough commented 2 years ago

should be able to use a custom joinmap. Have you tried that?

jkdevito commented 2 years ago

I have not implemented a custom joinMap before. However, I believe my issue is stemming from implementing the single DSP bridge and standalone instances of the source selector to get around the overlap. It appears the controls for the sourceSelector are still mapped to the single DSP bridge and do not account for the 25-join selector join range (each selector requires 2 joins).

jkdevito commented 2 years ago

For the time being, updated SIMPL to support individually bridging each component. I would like to discuss further, that we may need to update the plugin to protect the level controls to avoid future issues when having more than 25 source selectors.

TrevorPayne commented 1 year ago

Closing this issue.

Resolution Option 1: Individually Bridge Source Selectors Resolution Option 2: Use join remapping