PepperDash / epi-biamp-tesira

Plugin for controlling Biamp Tesira DSPs from within Essentials.
0 stars 2 forks source link

[FEATURE]-Polling for router-type Switcher #73

Closed cdenig closed 1 year ago

cdenig commented 1 year ago

Is your feature request related to a problem? Please describe. When using a "router" as a switcher type, add support for polling. Currently have a system with Crestron and Biamp-native (TEC-X) controls and Crestron needs to support switching and source sync from both platforms.

Describe the solution you'd like When the switcher type is a "router", send a "get input" poll string every XX seconds. Bonus points for configurable interval AND manual poll trigger support from bridge.

Describe alternatives you've considered Ask DSP engineer to change a single router into many separate source selector blocks. This would grossly over-complicate the DSP program.

Additional context NA

cdenig commented 1 year ago

@TrevorPayne I added this FR a while back. Looks like might tie in with Issue 72

cdenig commented 1 year ago

An individual Poll accessible via the Bridge would be great. Could manage cycle timing from SIMPL as well as custom polling (like following preset recalls known to affect Routers)

TrevorPayne commented 1 year ago

Because it's being defined as a source selector in the config, and it's not.

Add a type property with the value "router"

This works, it just needs to be better documented.

On Feb 10, 2023 8:42 AM, cdenig @.***> wrote:

@TrevorPaynehttps://github.com/TrevorPayne I added this FR a while back. Looks like might tie in with Issue 72https://github.com/PepperDash/epi-dsp-tesira/issues/72

— Reply to this email directly, view it on GitHubhttps://github.com/PepperDash/epi-dsp-tesira/issues/73#issuecomment-1425902645, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKQSYOSPVPBRKSCSVO53YCTWWZHTTANCNFSM6AAAAAARZPGTCM. You are receiving this because you were mentioned.Message ID: @.***>

cdenig commented 1 year ago

SwitcherControlXX are all defined as "type": "router"

Looks like the Subscribe() method for Switcher only supports subscribable sourceSelectors. Looks like there is no check for switcher Type at this point. Possible it is done elsewhere? How well does the CrosspointState function? Possible its polling logic could serve as a model for control points that are not subscribable?

Attached is essentials config (extension changed to allow attach) with switcher control blocks starting on Line 368. nyu01301_t04-subcellarAudio-p01-configurationFile-essentials.txt

TrevorPayne commented 1 year ago

We control this device just fine - Andrew K used it for a 62 output router block this week.

We just don't have a check to prevent the subscribe from happening. It's benign, albeit annoying, I believe.

You're welcome to add the check in the subscribe method and push up a PR ;)

On Feb 10, 2023 11:34 AM, cdenig @.***> wrote:

SwitcherControlXX are all defined as "type": "router"

Looks like the Subscribe() method for Switcher only supports subscribable sourceSelectors. Looks like there is no check for switcher Type at this point. Possible it is done elsewhere? How well does the CrosspointState function? Possible its polling logic could serve as a model for control points that are not subscribable?

Attached is essentials config (extension changed to allow attach) with switcher control blocks starting on Line 368. nyu01301_t04-subcellarAudio-p01-configurationFile-essentials.txthttps://github.com/PepperDash/epi-dsp-tesira/files/10709801/nyu01301_t04-subcellarAudio-p01-configurationFile-essentials.txt

— Reply to this email directly, view it on GitHubhttps://github.com/PepperDash/epi-dsp-tesira/issues/73#issuecomment-1426126612, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKQSYOVG23VRQEC3ZQSWJNDWWZ3ZJANCNFSM6AAAAAARZPGTCM. You are receiving this because you were mentioned.Message ID: @.***>