search

PepperlFuchs / pf_lidar_ros_driver

ROS driver for Pepperl+Fuchs R2000 and R2300 laser scanners
https://www.pepperl-fuchs.com/global/en/23097.htm
Apache License 2.0
37 stars 37 forks source link

Dyn reconfig start angle max points scan #49

Closed wsaihopfsg closed 3 years ago

wsaihopfsg commented 3 years ago

For https://github.com/PepperlFuchs/ROS_driver/issues/35#issuecomment-754384255

In the current code, the dynamic reconfiguration for start_angle & max_num_points_scan has no effect because these changes are not communicated to R2300 by set_scanoutput_config.

This commit has been tested for R2300 only, and no changes have been made for R2000.

hsd-dev commented 3 years ago

@wsaihopfsg thanks for the contribution! Could you please resolve the conflicts?

wsaihopfsg commented 3 years ago

@wsaihopfsg thanks for the contribution! Could you please resolve the conflicts?

I am done with this conflict resolution too. Thanks

hsd-dev commented 3 years ago

@wsaihopfsg this PR is behind https://github.com/PepperlFuchs/ROS_driver/pull/51. I have pushed couple of commits to this PR.