[WIP] Porting to ROS2 - Githubissues

PepperlFuchs / pf_lidar_ros_driver

ROS driver for Pepperl+Fuchs R2000 and R2300 laser scanners

https://www.pepperl-fuchs.com/global/en/23097.htm

Apache License 2.0

37 stars 37 forks source link

[WIP] Porting to ROS2 #82

Closed hsd-dev closed 2 years ago

hsd-dev commented 2 years ago

[ ] CI
[ ] pf_interfaces
- [ ] package.xml and CMakeLists.txt
[ ] pf_description
- [ ] package.xml and CMakeLists.txt
- [ ] launch files
[ ] pf_driver
- [ ] package.xml and CMakeLists.txt

hsd-dev commented 2 years ago

@wawanbreton I have added a very basic TODOs to the main description of the PR. Feel free to add to the list. Also let's try to make sure that the commits are created according to the list (e.g. one commit to port the package.xml and CMakeLists.txt)

hsd-dev commented 2 years ago

@wawanbreton do you see a checkbox on this page that says

Allow edits from maintainers

If yes, please check that box.

wawanbreton commented 2 years ago

Nice, I will take some time to update the TODO list. I don't see the checkbox you mention, maybe it is on the branch page ? I will take a look.

wawanbreton commented 2 years ago

Actually, it seems that I have no right on this PR, as you are its author. So I can't see how to edit the description, neither to give you the commit permission. Sorry I'm quite new with workflows on Github !

hsd-dev commented 2 years ago

@wawanbreton can you try to push your commits to https://github.com/PepperlFuchs/pf_lidar_ros_driver/pull/83? I could not find a solution to push to this PR.

hsd-dev commented 2 years ago

closing in favour of https://github.com/PepperlFuchs/pf_lidar_ros_driver/pull/83