search

PepperlFuchs / pf_lidar_ros_driver

ROS driver for Pepperl+Fuchs R2000 and R2300 laser scanners
https://www.pepperl-fuchs.com/global/en/23097.htm
Apache License 2.0
37 stars 37 forks source link

Feat hmi image #84

Closed hsd-dev closed 1 year ago

hsd-dev commented 2 years ago

behind https://github.com/PepperlFuchs/pf_lidar_ros_driver/pull/83

hsd-dev commented 1 year ago

rebased from latest main.
Note: Need to install libb64-dev explicitly

sudo apt-get install libb64-dev
ptruka commented 1 year ago

Due to the external dependency, the number of problems is likely to be greater than the added value of this feature. Since we already provide a convenient way to set the hmi_application_bitmap via dynamic reconfigure, the script could be run elsewhere by the user if necessary, and the resulting base64 string could be set via dynamic reconfigure.

hsd-dev commented 1 year ago

If anyone is interested in the feature, feel free to find an alternate solution without the need to install external libraries explicitly.

wawanbreton commented 1 year ago

Hi @ptruka The original purpose of the feature was to use the device as a screen, with possibly animations displayed on it. I understand this can still be achieved using dynamic parameters, but they are not meant to be set regularly. Anyway, I thought the libb64 was a very minimal dependancy, but maybe not. It should probably be possible to implement a very simple b64 conversion feature which would do the job.

hsd-dev commented 1 year ago

It should probably be possible to implement a very simple b64 conversion feature which would do the job.

That would be a nice contribution :) Thanks for the PR though!

wawanbreton commented 1 year ago

That would be a nice contribution :) Thanks for the PR though!

You're welcome ! I'm sorry for not being active recently, I see you have done the integration job :+1: The company I was working in is now closed, so I don't use the lidar anymore. I still have one at home so I may work on this feature if I find some time.

ptruka commented 1 year ago

thanks again for contributing this idea and the code. If we don't manage to get along without external dependency, i will refer to your code in the readme. This is certainly an added value for users who want to use the HMI with bitmaps.