Percapio / Codex

A GoodReads clone project written with Ruby on Rails and React
0 stars 0 forks source link

PA Review: User Authentication #1

Closed Percapio closed 6 years ago

Percapio commented 6 years ago
wongshington commented 6 years ago
Percapio commented 6 years ago

Fixed all additional changes that need to be made.

wongshington commented 6 years ago
Percapio commented 6 years ago
  1. for the first fix: I have, below in my session component. My understanding is that this should trigger after every render, yet its not. Do you have any ideas?

    componentDidMount() {
        this.props.clearErrors();
    }
  2. cleared the errors by creating an additional login container & component. My code is super wet now. Not sure how I could do this using only one component/container

  3. for the last fix: I added a transition-duration, and it seems to work for me. Please, let me know if it doesn't.

wongshington commented 6 years ago
Percapio commented 6 years ago

I did both, since a bigger container does look better