Percedal / FS22_UpgradableFactories

FS22 mod that increase production chains efficiency
GNU General Public License v3.0
28 stars 8 forks source link

WARNING: Mod is not compatible with FS22 Patch 1.11 and messes up Platinum Expansion factories / savegames! #44

Open sirupflex opened 1 year ago

sirupflex commented 1 year ago

Hi all,

Running FS22 on Steam / PC / Win11 and just upgraded to latest FS22 Patch 1.11. I have the upgradable factories mod installed and upgraded exactly one factory, the Iron Furnace (playing on Haut-Beyleron map). After installing the patch 1.11, I loaded the game, played with it, saw that the Iron Furnace only has around 2'000 iron ore lest, so I filled it with another 80'000 iron ore. Did some wood work, saved the game. Stopped playing and quit the game.

Some hours later I came back, loaded the game and realized that the Iron Furance says that it cannot produce because it has no goods (i.e. iron ore). Strange, as I just filled it and I didn't "sleep", i.e. still playing in the same month as when I filled the iron ore up. So I wanted to fill another 20'000 iron ore into the Iron Furnace but it said that storage is already full and it does not accept any further iron ore. Very strange.

My naive guess would be that it is either a huge funny coincidence or the mod and the patch 1.11 do not like each other. I looked at the upgradableFactories.xml file and (among all other factory entries) saw this:

_<production id="30" name="Eisenschmelzofen" level="2" basePrice="180000" totalValue="378000">
    <position x="-82.476471" y="130.007782"/>
    <fillLevels>
        <fillType id="131" fillType="WOODBEAM" fillLevel="82501"/>
        <fillType id="121" fillType="FLOORTILES" fillLevel="424"/>
    </fillLevels>_

Not sure why it says "Woodbeam" and "Floortiles". I guess that should be iron ore. Actually, the number 82'501 is the correct number of iron ore I should have in storage there. Not sure if the patch caused IDs to be messed up and now has the wrong goods assigned to (some) factories?

Also found e.g. the following entries that do not seem to be correct in terms of type of good assigned (assuming I do not misunderstand what it should mean):

_<production id="31" name="Möbelfabrik" level="1" basePrice="110000" totalValue="110000">
    <position x="-114.284485" y="129.626465"/>
    <fillLevels>
        <fillType id="109" fillType="LIQUIDSEEDTREATMENT" fillLevel="971"/>
        <fillType id="129" fillType="STAIRCASERAILING" fillLevel="30"/>
        <fillType id="125" fillType="PICTUREFRAME" fillLevel="0"/>
        <fillType id="63" fillType="BOARDS" fillLevel="0"/>
        <fillType id="121" fillType="FLOORTILES" fillLevel="3537"/>
        <fillType id="117" fillType="CATTREE" fillLevel="696"/>
    </fillLevels>
</production>
<production id="27" name="Bodenbelagsfabrik" level="1" basePrice="110000" totalValue="110000">
    <position x="602.750000" y="61.272373"/>
    <fillLevels>
        <fillType id="120" fillType="EASEL" fillLevel="476"/>
        <fillType id="125" fillType="PICTUREFRAME" fillLevel="0"/>
        <fillType id="63" fillType="BOARDS" fillLevel="0"/>
    </fillLevels>
</production>_
sirupflex commented 1 year ago

Ok, it's confirmed, the Upgradable Factories Mod is not compatible with FS 22 Patch 1.11 and messes up the placeable.xml file with invalid fillType data for factories belonging to the "Forestry DLC" (Platinum Expansion). This causes the factories to malfunction.

How I found out: I manually corrected the XML files placeables.xml and upgradableFactories.xml files based on previous backup files (just corrected the fillType for Forestry DLC Factories). Started up the game, and it was messed up again. Then I deinstalled the Upgradable Factories Mod, started up again with the corrected placeables.xml file and, finally, everything was fine. So, it seems the mod somehow gets confused with whatever was adapted in Patch 1.11 and messes up the fillType definition.

This mod cannot be used anymore until fixed. If you don't intend to fix it, I recommend to withdraw the mod completely as it causes factories to malfunction, which bascially kills an entire savegame if people are not tech geeks and know what to change in XML files (and have backup files available).

berntseb commented 1 year ago

I have partially fixed this locally, but still requires some work. The original author seems to not care about the mod anymore and I try to understand what needs to be done to have the mod working properly with changes.

The incompatibility is caused by two major issues. First: the filltype IDs are not updated correctly for the filltypes of a production when loading a savegame after any update on any production (patch or mod; other mod productions are also heavily impacted when mod updates add new filltypes to the production mod or especially the entire savegame). I have fixed this filltype update issue so far (locally) but the second issue is, that it is currently impossible to add the new filltypes to the production itself after the IDs are newly generated for the savegame. This is caused by the main structure how the mod gets filltypes through the Giants API. I need to understand the Giants API options deeper and most likely need to change main strategies of the mod how to load filltypes.

sirupflex commented 1 year ago

Thank you very much for your response and for all your work, it is appreciated! Personally, I decided not to use this mod any further. I only used it in one case and I can live without it. Although I see you did an excellent job to safe the mod as much as possible, for me personally the benefits of the mod are not worth the hassle it sooner or later will cause again.

In the Giants Forum, I got zero reaction on my posting about this, so I assume the mod is not really widely used. Question is if it's worth any further effort at all, but I leave that to you, of course. Thank you so much again for checking back and for trying to fix what the author didn't care to fix any more.

A general comment: As a user, I understand when mod authors cannot maintain their mods any more. In that case, latest when unmaintained mods are starting to cause trouble, I would appreciate, however, when authors would withdraw their mods from the repositories. Otherwise users will still find these broken mods, install it, and suffer the consequences.

Shad0wlife commented 10 months ago

So the issue here is that updates can change the filltype? Does the Name stay the same and the ID change? Or do the Ids get swapped around? Because I think fillTypes are bound to the game, not the savegame specifically.

Though, when looking at the vanilla savegame files (eg. placeables.xml, where the productions are usually managed) the fillTypes are only identified by name (eg. "BREAD"), not the id, which makes me assume the ID is not actually fixed, but the name is. I'm gonna check if I can make the mod drop the id completely and also only use the name.

Shad0wlife commented 10 months ago

Ok, fixed it. Just getting the filltype index by name when setting the capacities (instead of using the index from the xml) solves it. Tested it by intentionally switching around the ids in the xml file, and everything still worked.

I'm gonna put this change on my fork one of these days after testing some more stuff (aka multiplayer support) I'm working on.

Edit: @sirupflex Here is the fork of berntseb's fork with the filltype fix: https://github.com/Shad0wlife/FS22_UpgradableFactories/tree/main

MimirDroid commented 10 months ago

@Shad0wlife That is fantastic! Nice find. Thanks for posting the fix for it. I had 28 hours into The new map. Went to save my game and it stuck in the save loop. Corrupted, so I restored the newest backup and it did it again when I saved. Your find and fix solved the problem

SirAeleon commented 9 months ago

@Shad0wlife Thank you sir. I just encountered the above quirks with premium edition, where I filled parsnip into my factory and after a reload it was full of carrots. The research brought me here and I'm thankful that you already solved my problem :)

FirenzeIT commented 9 months ago

Hi @Percedal, yes isn't compatible with last update 1.13.1 Premium/Platinum edition, i have always errors and crash whole game. I hope you can fix them ASAP, thank you.

1248130_20231116060448_1

Shad0wlife commented 9 months ago

Percedal has been inactive for a while sadly. That issue looks new, do you have any other mods besides this and Revamp installed that affect productions?

If no, did you hide any inactive productions or so with revamp? That would be my only guess, but I can't test that until sometime in the weekend.

FirenzeIT commented 9 months ago

Percedal has been inactive for a while sadly. That issue looks new, do you have any other mods besides this and Revamp installed that affect productions?

If no, did you hide any inactive productions or so with revamp? That would be my only guess, but I can't test that until sometime in the weekend.

Hi, yes i have a Revamp (last update) installed,but this errors having also without any others mods... I just uninstalled because with this, i can't play the game... I don't have any inactive productions (i try purchased one factory for testing, probably this mod not works very well with last update of the game)...

I tryied also a pre-release version of this mod, same issues. For works (and compatibility) with Revamp, how can i settings this??

2023-11-24 13:55 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:55 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:55 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:55 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:55 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:55 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:55 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:55 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:55 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:55 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:55 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:55 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:55 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:55 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:55 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:55 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:55 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:55 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:55 UpgradableFactories: Request upgrade Forno to level 1 of 10 [cost: 55.000 € | money: 1.368.323 €] 2023-11-24 13:55 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 UpgradableFactories: Request upgrade Forno to level 2 of 10 [cost: 60.000 € | money: 1.313.323 €] 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 UpgradableFactories: Request upgrade Forno to level 3 of 10 [cost: 65.000 € | money: 1.253.323 €] 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 UpgradableFactories: Request upgrade Forno to level 4 of 10 [cost: 70.000 € | money: 1.188.323 €] 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-11-24 13:56 Error: Running LUA method 'update'. C:/Users/*****/Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value)

FirenzeIT commented 9 months ago

EDIT: today (also without other mods), i have too many errors/issues with this mod (both version from modhub and 1.2.1.0 on github), need update this mod for works with v1.13.1 of FS22..

2023-12-09 21:28 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:28 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:28 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:28 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:28 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:28 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:28 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:28 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:28 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:29 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:29 UpgradableFactories: Request upgrade Forno to level 1 of 10 [cost: 55.000 $ | money: 1.384.129 $] 2023-12-09 21:29 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:29 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:29 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:29 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:29 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:29 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:29 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:29 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:29 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:29 UpgradableFactories: Request upgrade Forno to level 2 of 10 [cost: 60.000 $ | money: 1.329.126 $] 2023-12-09 21:29 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:29 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:29 Error: Running LUA method 'mouseEvent'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:29 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:29 Error: Running LUA method 'update'. C:/Users//Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:29 Error: Running LUA method 'mouseEvent'. C:/Users/*****/Documents/My Games/FarmingSimulator2022/mods/FS22_UpgradableFactories/InGameMenuUpgradableFactories.lua:58: attempt to index local 'prodpoint' (a nil value) 2023-12-09 21:29 UpgradableFactories: Request upgrade Forno to level 3 of 10 [cost: 65.000 $ | money: 1.269.120 $] 2023-12-09 21:29 UpgradableFactories: Upgrade confirmed

Shad0wlife commented 9 months ago

I still cannot reproduce this. It works fine for me on the current game version in singleplayer with the fixes from berntseb - even with other mods and revamp. I don't have the Premium or Platinum DLCs though, but I doubt that those are the issue.

I also just double checked the code of the game. The game itself checks if that value is nil, the mod does not. So I guess the issue can technically happen. I just don't understand why it doesn't really happen for anyone else.

Shad0wlife commented 9 months ago

@FirenzeIT try my updated fork now, I added an extra nil check in the line where it errors for you:

https://github.com/Shad0wlife/FS22_UpgradableFactories/tree/main

FirenzeIT commented 9 months ago

@FirenzeIT try my updated fork now, I added an extra nil check in the line where it errors for you:

https://github.com/Shad0wlife/FS22_UpgradableFactories/tree/main

Hi, wow now it's works very well (with your last updated){map default ElmCreek}; however, i have this nil value in the log too, it's normal??:

2023-12-10 03:58 UpgradableFactories: initialize production Forno [has custom env: nil] 2023-12-10 03:58 data/placeables/lizard/productionPoints/carpenterUS//carpenterUS.i3d (3.78 ms) 2023-12-10 03:58 data/placeables/lizard/productionPoints/carpenterUS/props.i3d (1.62 ms) 2023-12-10 03:58 UpgradableFactories: initialize production Carpenteria [has custom env: nil] 2023-12-10 03:58 data/placeables/lizard/productionPoints/cerealFactory/cerealFactory.i3d (4.96 ms) 2023-12-10 03:58 data/placeables/lizard/productionPoints/cerealFactory/props.i3d (1.79 ms) 2023-12-10 03:58 UpgradableFactories: initialize production Fabbrica di cereali [has custom env: nil] 2023-12-10 03:58 data/placeables/lizard/productionPoints/dairyUS/dairyUS.i3d (4.09 ms) 2023-12-10 03:58 data/placeables/lizard/productionPoints/dairyUS/props.i3d (0.71 ms) 2023-12-10 03:58 UpgradableFactories: initialize production Caseificio [has custom env: nil] 2023-12-10 03:58 data/placeables/lizard/sellingPoints/fastFoodRestaurant/fastFoodRestaurant.i3d (5.06 ms) 2023-12-10 03:58 data/placeables/lizard/sellingPoints/fastFoodRestaurant/props.i3d (0.72 ms) 2023-12-10 03:58 Info: checking selling station: 2023-12-10 03:58 Info: unload 1: POTATO MAIZE FLOUR SUNFLOWER_OIL CANOLA_OIL OLIVE_OIL BUTTER CHEESE SUGAR EGG CAKE HONEY TOMATO LETTUCE STRAWBERRY GRAPE GRAPEJUICE / nil 2023-12-10 03:58 data/placeables/lizard/productionPoints/oilPlant/oilPlant.i3d (4.41 ms) 2023-12-10 03:58 data/placeables/sellingStationGeneric/sellingStationGenericNoCover.i3d (3.28 ms) 2023-12-10 03:58 data/placeables/lizard/productionPoints/oilPlant/props.i3d (0.85 ms) 2023-12-10 03:58 UpgradableFactories: initialize production Frantoio [has custom env: nil] 2023-12-10 03:58 data/placeables/lizard/productionPoints/raisinFactory/raisinFactory.i3d (6.41 ms) 2023-12-10 03:58 data/placeables/lizard/productionPoints/raisinFactory/props.i3d (1.06 ms) 2023-12-10 03:58 UpgradableFactories: initialize production Lavorazione dell'uva [has custom env: nil] 2023-12-10 03:58 data/placeables/lizard/productionPoints/spinneryUS/spinneryUS.i3d (3.77 ms) 2023-12-10 03:58 data/placeables/lizard/productionPoints/spinneryUS/props.i3d (0.53 ms) 2023-12-10 03:58 UpgradableFactories: initialize production Filanda [has custom env: nil] 2023-12-10 03:58 data/placeables/mapUS/productionPointGrainMill/productionPointGrainMill.i3d (0.25 ms) 2023-12-10 03:58 UpgradableFactories: initialize production Mulino per grano [has custom env: nil] 2023-12-10 03:58 data/placeables/mapUS/sawmill/sawmillTriggers.i3d (2.49 ms) 2023-12-10 03:58 UpgradableFactories: initialize production Segheria [has custom env: nil] 2023-12-10 03:58 data/placeables/mapUS/sellingStationGeneric/sellingStationFarmersMarket.i3d (0.19 ms) 2023-12-10 03:58 Info: ** checking selling station: 2023-12-10 03:58 Info: unload 1: WHEAT BARLEY CANOLA SUNFLOWER SOYBEAN MAIZE OAT SORGHUM / nil 2023-12-10 03:58 Info: unload 2: POTATO SUGARBEET SUGARCANE WOODCHIPS DRYGRASS_WINDROW EGG WOOL MILK BREAD HONEY BUTTER FLOUR CHEESE SUNFLOWER_OIL CANOLA_OIL OLIVE_OIL TOMATO LETTUCE STRAWBERRY RAISINS GRAPEJUICE SEEDS / nil 2023-12-10 03:58 Info: unload 3: WOODCHIPS COTTON DRYGRASS_WINDROW ROUNDBALE_WOOD / nil 2023-12-10 03:58 Info: add CHAFF as fillType(29) to sellPoint 2023-12-10 03:58 data/placeables/sellingStationGeneric/sellingStationGeneric.i3d (1.03 ms) 2023-12-10 03:58 Info: checking selling station: 2023-12-10 03:58 Info: * unload 1: WHEAT BARLEY CANOLA SUNFLOWER SOYBEAN MAIZE OAT SORGHUM POTATO SUGARBEET SUGARCANE / nil 2023-12-10 03:58 data/placeables/mapUS/sellingStationBowlingCenter/sellingStationBowlingCenter.i3d (0.15 ms) 2023-12-10 03:58 Info: * checking selling station: 2023-12-10 03:58 Info: unload 1: BREAD CAKE CHEESE GRAPEJUICE CHOCOLATE SUNFLOWER_OIL STRAWBERRY LETTUCE TOMATO / nil 2023-12-10 03:58 data/placeables/mapUS/sellingStationShoppingMall/sellingStationShoppingMall.i3d (0.14 ms) 2023-12-10 03:58 Info: checking selling station: 2023-12-10 03:58 Info: * unload 1: FLOUR BREAD CAKE BUTTER CHEESE FABRIC SUGAR CLOTHES CEREAL SUNFLOWER_OIL CANOLA_OIL OLIVE_OIL GRAPE OLIVE RAISINS GRAPEJUICE CHOCOLATE FURNITURE STRAWBERRY LETTUCE TOMATO / nil

FirenzeIT commented 9 months ago

Hi @Shad0wlife, and another things: now not works mission contract (example plowing), not have any progress of the job.. Boh 🤷🏻

EDIT: I finded a mod culprit for broken mission contract: Enhanced Crop Destruction.

Perhaps, i have also this warning-nil, it's normal or need to fix??

2023-12-11 04:52 UpgradableFactories: initialize production Impianto a biogas 1MW [has custom env: nil] 2023-12-11 04:52 data/placeables/planET/bgaBunkerSilo/bgaBunkerSilo.i3d (0.34 ms) 2023-12-11 04:52 data/placeables/lizard/weighingStation/weighingStationLarge/weighingStationLarge.i3d (4.49 ms) 2023-12-11 04:52 data/shared/assets/lights/terraLed/fluorescentTube50W.i3d (1.10 ms) 2023-12-11 04:52 data/placeables/planET/bgaHall/bgaHall.i3d (3.65 ms) 2023-12-11 04:52 data/placeables/lizard/chargingStation/chargingStation.i3d (2.13 ms) 2023-12-11 04:52 data/placeables/lizard/biogasStation/biogasStation.i3d (1.79 ms) 2023-12-11 04:52 data/placeables/lizard/sellingPoints/debrisCrusher/debrisCrusher.i3d (4.49 ms) 2023-12-11 04:52 Info: checking selling station: 2023-12-11 04:52 Info: unload 1: STONE / nil 2023-12-11 04:52 Info: unload 2: STONE / nil 2023-12-11 04:52 Info (data/maps/mapUS/placeables.xml): Placeable 'data/placeables/mapUS/farmBuildings/farmHouse/farmHouse02.xml' is not allowed to be loaded 2023-12-11 04:52 data/placeables/mapUS/farmBuildings/farmGarage/farmGarage01.i3d (6.18 ms) 2023-12-11 04:52 data/placeables/mapUS/farmBuildings/farmGarage/attachments.i3d (5.04 ms) 2023-12-11 04:52 data/placeables/mapUS/farmBuildings/farmGarage/props.i3d (14.65 ms) 2023-12-11 04:52 data/placeables/mapUS/farmBuildings/farmBarn/farmBarn02.i3d (9.23 ms) 2023-12-11 04:52 data/placeables/mapUS/farmBuildings/farmBarn/farmSilo01.i3d (2.78 ms) 2023-12-11 04:52 data/placeables/mapUS/farmBuildings/farmBarn/attachments.i3d (2.31 ms) 2023-12-11 04:52 data/placeables/mapUS/farmBuildings/farmBarn/props.i3d (10.75 ms) 2023-12-11 04:52 data/placeables/mapUS/farmBuildings/farmShed/farmShed.i3d (0.88 ms) 2023-12-11 04:52 data/placeables/mapUS/farmBuildings/farmShed/attachments.i3d (0.82 ms) 2023-12-11 04:52 data/placeables/mapUS/farmBuildings/drainageBoard/drainageBoard.i3d (0.37 ms) 2023-12-11 04:52 data/placeables/mapUS/farmBuildings/slideSwing/slideSwing.i3d (0.41 ms) 2023-12-11 04:52 data/placeables/mapUS/farmBuildings/mobileBridge/mobileBridge.i3d (0.39 ms) 2023-12-11 04:52 data/placeables/mapUS/farmBuildings/auxiliaryFarms/cowFarm.i3d (17.84 ms) 2023-12-11 04:52 data/placeables/mapUS/farmBuildings/auxiliaryFarms/pigFarm.i3d (13.86 ms) 2023-12-11 04:52 data/placeables/mapUS/farmBuildings/auxiliaryFarms/sheepFarm.i3d (14.08 ms) 2023-12-11 04:52 data/placeables/mapUS/farmBuildings/auxiliaryFarms/horseRanch.i3d (17.07 ms) 2023-12-11 04:52 data/placeables/lizard/oldBarn/oldBarn.i3d (4.08 ms) 2023-12-11 04:52 Info (data/maps/mapUS/placeables.xml): Placeable 'data/placeables/lizard/waterTanks/level02/waterTankLevel02.xml' is not allowed to be loaded 2023-12-11 04:52 Info (data/maps/mapUS/placeables.xml): Placeable 'data/placeables/unia/farma/farma400/farma400.xml' is not allowed to be loaded 2023-12-11 04:52 data/placeables/mapUS/sellingStationBales/sellingStationBales.i3d (0.21 ms) 2023-12-11 04:52 Info: checking selling station: 2023-12-11 04:52 Info: unload 1: STRAW DRYGRASS_WINDROW GRASS_WINDROW SILAGE SUGARBEET_CUT FORAGE / nil 2023-12-11 04:52 Info: add CHAFF as fillType(6) to sellPoint 2023-12-11 04:52 data/placeables/mapUS/sellingStationWoodHeatingPlant/sellingStationWoodHeatingPlant.i3d (0.24 ms) 2023-12-11 04:52 Info: checking selling station: 2023-12-11 04:52 Info: unload 1: WOODCHIPS STRAW / nil 2023-12-11 04:52 Info: unload 2: WOODCHIPS STRAW / nil 2023-12-11 04:52 Info: unload 3: WOOD / nil 2023-12-11 04:52 Info: add CHAFF as fillType(0) to sellPoint 2023-12-11 04:52 data/placeables/mapUS/sellingStationTrain/sellingStationTrain.i3d (0.10 ms) 2023-12-11 04:52 data/placeables/mapUS/sellingStationWoodTrain/sellingStationWoodTrain.i3d (0.18 ms) 2023-12-11 04:52 data/placeables/lizard/productionPoints/bakeryUS/bakeryUS.i3d (3.82 ms) 2023-12-11 04:52 data/placeables/lizard/productionPoints/bakeryUS/props.i3d (3.78 ms) 2023-12-11 04:52 data/shared/assets/lights/lizard/buildings/industrialWallLight.i3d (0.23 ms) 2023-12-11 04:52 UpgradableFactories: initialize production Forno [has custom env: nil] 2023-12-11 04:52 data/placeables/lizard/productionPoints/carpenterUS//carpenterUS.i3d (3.96 ms) 2023-12-11 04:52 data/placeables/lizard/productionPoints/carpenterUS/props.i3d (1.60 ms) 2023-12-11 04:52 UpgradableFactories: initialize production Carpenteria [has custom env: nil] 2023-12-11 04:52 data/placeables/lizard/productionPoints/cerealFactory/cerealFactory.i3d (4.61 ms) 2023-12-11 04:52 data/placeables/lizard/productionPoints/cerealFactory/props.i3d (1.52 ms) 2023-12-11 04:52 UpgradableFactories: initialize production Fabbrica di cereali [has custom env: nil] 2023-12-11 04:52 data/placeables/lizard/productionPoints/dairyUS/dairyUS.i3d (4.35 ms) 2023-12-11 04:52 data/placeables/lizard/productionPoints/dairyUS/props.i3d (0.74 ms) 2023-12-11 04:52 UpgradableFactories: initialize production Caseificio [has custom env: nil] 2023-12-11 04:52 data/placeables/lizard/sellingPoints/fastFoodRestaurant/fastFoodRestaurant.i3d (5.53 ms) 2023-12-11 04:52 data/placeables/lizard/sellingPoints/fastFoodRestaurant/props.i3d (0.66 ms) 2023-12-11 04:52 Info: checking selling station: 2023-12-11 04:52 Info: * unload 1: POTATO MAIZE FLOUR SUNFLOWER_OIL CANOLA_OIL OLIVE_OIL BUTTER CHEESE SUGAR EGG CAKE HONEY TOMATO LETTUCE STRAWBERRY GRAPE GRAPEJUICE / nil 2023-12-11 04:52 data/placeables/lizard/productionPoints/oilPlant/oilPlant.i3d (5.70 ms) 2023-12-11 04:52 data/placeables/sellingStationGeneric/sellingStationGenericNoCover.i3d (3.31 ms) 2023-12-11 04:52 data/placeables/lizard/productionPoints/oilPlant/props.i3d (1.33 ms) 2023-12-11 04:52 UpgradableFactories: initialize production Frantoio [has custom env: nil] 2023-12-11 04:52 data/placeables/lizard/productionPoints/raisinFactory/raisinFactory.i3d (6.84 ms) 2023-12-11 04:52 data/placeables/lizard/productionPoints/raisinFactory/props.i3d (1.09 ms) 2023-12-11 04:52 UpgradableFactories: initialize production Lavorazione dell'uva [has custom env: nil] 2023-12-11 04:52 data/placeables/lizard/productionPoints/spinneryUS/spinneryUS.i3d (4.23 ms) 2023-12-11 04:52 data/placeables/lizard/productionPoints/spinneryUS/props.i3d (0.55 ms) 2023-12-11 04:52 UpgradableFactories: initialize production Filanda [has custom env: nil] 2023-12-11 04:52 data/placeables/mapUS/productionPointGrainMill/productionPointGrainMill.i3d (0.30 ms) 2023-12-11 04:52 UpgradableFactories: initialize production Mulino per grano [has custom env: nil] 2023-12-11 04:52 data/placeables/mapUS/sawmill/sawmillTriggers.i3d (2.59 ms) 2023-12-11 04:52 UpgradableFactories: initialize production Segheria [has custom env: nil]

Shad0wlife commented 9 months ago

Didn't have time to check that yet, and probably won't until friday

FirenzeIT commented 9 months ago

Didn't have time to check that yet, and probably won't until friday

No probem bro, take your time... also because your modifying of few days ago, works well. Thank you for your work 👌and have a nice holiday !!!

Shad0wlife commented 8 months ago

@FirenzeIT the "has custom env: nil" is intended and correct. It means it's not from eg. Pumps and hoses DLC or a mod that separates its buildings somehow.

I could maybe try and change that to a "no" so it looks less like an error.

FirenzeIT commented 8 months ago

@FirenzeIT the "has custom env: nil" is intended and correct. It means it's not from eg. Pumps and hoses DLC or a mod that separates its buildings somehow.

I could maybe try and change that to a "no" so it looks less like an error.

ok, you can try to change that please, if possible; At least then I can try it. Can i cancel README.md inside the zip without any issues??

Thank you and have a merry XMAS and happy holiday 👍🏻 💯

PS: So it's normal this messages below??

2023-12-25 10:52 UpgradableFactories: initialize production Impianto a biogas 1MW [has custom env: nil] 2023-12-25 10:52 data/placeables/planET/bgaBunkerSilo/bgaBunkerSilo.i3d (0.82 ms) 2023-12-25 10:52 data/placeables/lizard/weighingStation/weighingStationLarge/weighingStationLarge.i3d (6.57 ms) 2023-12-25 10:52 data/shared/assets/lights/terraLed/fluorescentTube50W.i3d (2.57 ms) 2023-12-25 10:52 data/placeables/planET/bgaHall/bgaHall.i3d (6.14 ms) 2023-12-25 10:52 data/placeables/lizard/chargingStation/chargingStation.i3d (3.58 ms) 2023-12-25 10:52 data/placeables/lizard/biogasStation/biogasStation.i3d (3.28 ms) 2023-12-25 10:52 data/placeables/lizard/sellingPoints/debrisCrusher/debrisCrusher.i3d (6.53 ms) 2023-12-25 10:52 Info: checking selling station: 2023-12-25 10:52 Info: unload 1: STONE / nil 2023-12-25 10:52 Info: unload 2: STONE / nil 2023-12-25 10:52 Info (data/maps/mapUS/placeables.xml): Placeable 'data/placeables/mapUS/farmBuildings/farmHouse/farmHouse02.xml' is not allowed to be loaded 2023-12-25 10:52 data/placeables/mapUS/farmBuildings/farmGarage/farmGarage01.i3d (10.70 ms) 2023-12-25 10:52 data/placeables/mapUS/farmBuildings/farmGarage/attachments.i3d (6.47 ms) 2023-12-25 10:52 data/placeables/mapUS/farmBuildings/farmGarage/props.i3d (15.51 ms) 2023-12-25 10:52 data/placeables/mapUS/farmBuildings/farmBarn/farmBarn02.i3d (12.68 ms) 2023-12-25 10:52 data/placeables/mapUS/farmBuildings/farmBarn/farmSilo01.i3d (6.20 ms) 2023-12-25 10:52 data/placeables/mapUS/farmBuildings/farmBarn/attachments.i3d (2.97 ms) 2023-12-25 10:52 data/placeables/mapUS/farmBuildings/farmBarn/props.i3d (12.00 ms) 2023-12-25 10:52 data/placeables/mapUS/farmBuildings/farmShed/farmShed.i3d (1.30 ms) 2023-12-25 10:52 data/placeables/mapUS/farmBuildings/farmShed/attachments.i3d (1.40 ms) 2023-12-25 10:52 data/placeables/mapUS/farmBuildings/drainageBoard/drainageBoard.i3d (0.81 ms) 2023-12-25 10:52 data/placeables/mapUS/farmBuildings/slideSwing/slideSwing.i3d (1.01 ms) 2023-12-25 10:52 data/placeables/mapUS/farmBuildings/mobileBridge/mobileBridge.i3d (1.00 ms) 2023-12-25 10:52 data/placeables/mapUS/farmBuildings/auxiliaryFarms/cowFarm.i3d (17.28 ms) 2023-12-25 10:52 data/placeables/mapUS/farmBuildings/auxiliaryFarms/pigFarm.i3d (14.90 ms) 2023-12-25 10:52 data/placeables/mapUS/farmBuildings/auxiliaryFarms/sheepFarm.i3d (12.78 ms) 2023-12-25 10:52 data/placeables/mapUS/farmBuildings/auxiliaryFarms/horseRanch.i3d (16.04 ms) 2023-12-25 10:52 data/placeables/lizard/oldBarn/oldBarn.i3d (4.88 ms) 2023-12-25 10:52 Info (data/maps/mapUS/placeables.xml): Placeable 'data/placeables/lizard/waterTanks/level02/waterTankLevel02.xml' is not allowed to be loaded 2023-12-25 10:52 Info (data/maps/mapUS/placeables.xml): Placeable 'data/placeables/unia/farma/farma400/farma400.xml' is not allowed to be loaded 2023-12-25 10:52 data/placeables/mapUS/sellingStationBales/sellingStationBales.i3d (0.62 ms) 2023-12-25 10:52 Info: checking selling station: 2023-12-25 10:52 Info: unload 1: STRAW DRYGRASS_WINDROW GRASS_WINDROW SILAGE SUGARBEET_CUT FORAGE / nil 2023-12-25 10:52 Info: add CHAFF as fillType(6) to sellPoint 2023-12-25 10:52 data/placeables/mapUS/sellingStationWoodHeatingPlant/sellingStationWoodHeatingPlant.i3d (0.63 ms) 2023-12-25 10:52 Info: checking selling station: 2023-12-25 10:52 Info: unload 1: WOODCHIPS STRAW / nil 2023-12-25 10:52 Info: unload 2: WOODCHIPS STRAW / nil 2023-12-25 10:52 Info: unload 3: WOOD / nil 2023-12-25 10:52 Info: add CHAFF as fillType(0) to sellPoint 2023-12-25 10:52 data/placeables/mapUS/sellingStationTrain/sellingStationTrain.i3d (0.14 ms) 2023-12-25 10:52 data/placeables/mapUS/sellingStationWoodTrain/sellingStationWoodTrain.i3d (0.52 ms) 2023-12-25 10:52 data/placeables/lizard/productionPoints/bakeryUS/bakeryUS.i3d (7.38 ms) 2023-12-25 10:52 data/placeables/lizard/productionPoints/bakeryUS/props.i3d (5.45 ms) 2023-12-25 10:52 data/shared/assets/lights/lizard/buildings/industrialWallLight.i3d (0.59 ms) 2023-12-25 10:52 onLoad 2023-12-25 10:52 isOwned: false 2023-12-25 10:52 farmId: 0 2023-12-25 10:52 UpgradableFactories: initialize production Forno [has custom env: nil] 2023-12-25 10:52 data/placeables/lizard/productionPoints/carpenterUS//carpenterUS.i3d (7.78 ms) 2023-12-25 10:52 data/placeables/lizard/productionPoints/carpenterUS/props.i3d (3.11 ms) 2023-12-25 10:52 onLoad 2023-12-25 10:52 isOwned: false 2023-12-25 10:52 farmId: 0 2023-12-25 10:52 UpgradableFactories: initialize production Carpenteria [has custom env: nil] 2023-12-25 10:52 data/placeables/lizard/productionPoints/cerealFactory/cerealFactory.i3d (5.27 ms) 2023-12-25 10:52 data/placeables/lizard/productionPoints/cerealFactory/props.i3d (2.16 ms) 2023-12-25 10:52 onLoad 2023-12-25 10:52 isOwned: false 2023-12-25 10:52 farmId: 0 2023-12-25 10:52 UpgradableFactories: initialize production Fabbrica di cereali [has custom env: nil] 2023-12-25 10:52 data/placeables/lizard/productionPoints/dairyUS/dairyUS.i3d (5.86 ms) 2023-12-25 10:52 data/placeables/lizard/productionPoints/dairyUS/props.i3d (1.32 ms) 2023-12-25 10:52 onLoad 2023-12-25 10:52 isOwned: false 2023-12-25 10:52 farmId: 0 2023-12-25 10:52 UpgradableFactories: initialize production Caseificio [has custom env: nil] 2023-12-25 10:52 data/placeables/lizard/sellingPoints/fastFoodRestaurant/fastFoodRestaurant.i3d (9.00 ms) 2023-12-25 10:52 data/placeables/lizard/sellingPoints/fastFoodRestaurant/props.i3d (1.20 ms) 2023-12-25 10:52 Info: checking selling station: 2023-12-25 10:52 Info: * unload 1: POTATO MAIZE FLOUR SUNFLOWER_OIL CANOLA_OIL OLIVE_OIL BUTTER CHEESE SUGAR EGG CAKE HONEY TOMATO LETTUCE STRAWBERRY GRAPE GRAPEJUICE GOATMILK / nil 2023-12-25 10:52 data/placeables/lizard/productionPoints/oilPlant/oilPlant.i3d (4.88 ms) 2023-12-25 10:52 data/placeables/sellingStationGeneric/sellingStationGenericNoCover.i3d (5.89 ms) 2023-12-25 10:52 data/placeables/lizard/productionPoints/oilPlant/props.i3d (1.37 ms) 2023-12-25 10:52 onLoad 2023-12-25 10:52 isOwned: false 2023-12-25 10:52 farmId: 0 2023-12-25 10:52 UpgradableFactories: initialize production Frantoio [has custom env: nil] 2023-12-25 10:52 data/placeables/lizard/productionPoints/raisinFactory/raisinFactory.i3d (11.41 ms) 2023-12-25 10:52 data/placeables/lizard/productionPoints/raisinFactory/props.i3d (1.71 ms) 2023-12-25 10:52 onLoad 2023-12-25 10:52 isOwned: false 2023-12-25 10:52 farmId: 0 2023-12-25 10:52 UpgradableFactories: initialize production Lavorazione dell'uva [has custom env: nil] 2023-12-25 10:52 data/placeables/lizard/productionPoints/spinneryUS/spinneryUS.i3d (7.65 ms) 2023-12-25 10:52 data/placeables/lizard/productionPoints/spinneryUS/props.i3d (1.28 ms) 2023-12-25 10:52 onLoad 2023-12-25 10:52 isOwned: false 2023-12-25 10:52 farmId: 0 2023-12-25 10:52 UpgradableFactories: initialize production Filanda [has custom env: nil] 2023-12-25 10:52 data/placeables/mapUS/productionPointGrainMill/productionPointGrainMill.i3d (0.65 ms) 2023-12-25 10:52 onLoad 2023-12-25 10:52 isOwned: false 2023-12-25 10:52 farmId: 0 2023-12-25 10:52 UpgradableFactories: initialize production Mulino per grano [has custom env: nil] 2023-12-25 10:52 data/placeables/mapUS/sawmill/sawmillTriggers.i3d (3.96 ms) 2023-12-25 10:52 onLoad 2023-12-25 10:52 isOwned: false 2023-12-25 10:52 farmId: 0 2023-12-25 10:52 UpgradableFactories: initialize production Segheria [has custom env: nil] 2023-12-25 10:52 data/placeables/mapUS/sellingStationGeneric/sellingStationFarmersMarket.i3d (0.53 ms) 2023-12-25 10:52 Info: checking selling station: 2023-12-25 10:52 Info: unload 1: WHEAT BARLEY CANOLA SUNFLOWER SOYBEAN MAIZE OAT SORGHUM / nil 2023-12-25 10:52 Info: unload 2: POTATO SUGARBEET SUGARCANE WOODCHIPS DRYGRASS_WINDROW EGG WOOL MILK BREAD HONEY BUTTER FLOUR CHEESE SUNFLOWER_OIL CANOLA_OIL OLIVE_OIL TOMATO LETTUCE STRAWBERRY RAISINS GRAPEJUICE SEEDS GOATMILK / nil 2023-12-25 10:52 Info: unload 3: WOODCHIPS COTTON DRYGRASS_WINDROW ROUNDBALE_WOOD / nil 2023-12-25 10:52 Info: add CHAFF as fillType(30) to sellPoint 2023-12-25 10:52 data/placeables/sellingStationGeneric/sellingStationGeneric.i3d (2.21 ms) 2023-12-25 10:52 Info: checking selling station: 2023-12-25 10:52 Info: * unload 1: WHEAT BARLEY CANOLA SUNFLOWER SOYBEAN MAIZE OAT SORGHUM POTATO SUGARBEET SUGARCANE / nil 2023-12-25 10:52 data/placeables/mapUS/sellingStationBowlingCenter/sellingStationBowlingCenter.i3d (0.54 ms) 2023-12-25 10:52 Info: * checking selling station: 2023-12-25 10:52 Info: unload 1: BREAD CAKE CHEESE GRAPEJUICE CHOCOLATE SUNFLOWER_OIL STRAWBERRY LETTUCE TOMATO / nil 2023-12-25 10:53 data/placeables/mapUS/sellingStationShoppingMall/sellingStationShoppingMall.i3d (0.66 ms) 2023-12-25 10:53 Info: checking selling station: 2023-12-25 10:53 Info: * unload 1: FLOUR BREAD CAKE BUTTER CHEESE FABRIC SUGAR CLOTHES CEREAL SUNFLOWER_OIL CANOLA_OIL OLIVE_OIL GRAPE OLIVE RAISINS GRAPEJUICE CHOCOLATE FURNITURE STRAWBERRY LETTUCE TOMATO GOATMILK / nil

NordicTaurus commented 8 months ago

Thanks for taking the time to look in to this!

Am I doing something wrong? I zipped the content of https://github.com/Shad0wlife/FS22_UpgradableFactories/tree/main and swapped it out for the original FS22_UpgradableFactories.zip. There seem to be no errors related to it in the log, but loading hangs at 99% with message 2024-01-17 10:28 Error: Running LUA method 'onSaveGameLoadingFinished'. dataS/scripts/utils/MathUtil.lua(1100) : attempt to perform arithmetic on local 'y1' (a nil value)

Shad0wlife commented 8 months ago

That's really odd. Especially because the error isn't actually in the mod's code. Though it does add to the savegame finishing part I believe. And this didn't happen with the broken version of the mod (or without the mod uninstalled)?

Because unlike the multiplayer fix, there's not actually much that was changed...

But my best guess is that some coordinate thing is breaking so I'll look into that.

NordicTaurus commented 8 months ago

This didn't happen with the original, no.

You're a legend mate

Shad0wlife commented 8 months ago

Aw hell I know what the issue is... How tf did that not happen before? Anyone who used the broken mod and upgraded to the "fixed" version without deleting the mod save xml file should have had this...

I don't know if I'll have the time to fix it today...

I basically need a compatibility code that tries its best to find a production with the old coordinates.

NordicTaurus commented 8 months ago

Deleted which file you say? Mod save xml?

Shad0wlife commented 8 months ago

The mod saves its levels to a file. That file identifies the factories by its coordinates, but was bugged in the OG version. The fix was to use a different coordinate, but that is missing in the file until it was saved once with the fix.

Deleting the file will remove the crash but also remove any levelups of your factories you have done, without refunding any money.

If you still want to do so, it should be upgradableFactories.xml in the save folder.

I'll try to make the mod work with the legacy data as well though, just maybe not today but up until friday.

FirenzeIT commented 8 months ago

Hi @Shad0wlife, i downloaded and tried last update of this mod (16 Jan updated), but i have always 2024-01-19 01:31 UpgradableFactories: initialize production Lavorazione dell'uva [has custom env: nil] 2024-01-19 01:31 data/placeables/lizard/productionPoints/spinneryUS/spinneryUS.i3d (4.17 ms) 2024-01-19 01:31 data/placeables/lizard/productionPoints/spinneryUS/props.i3d (0.53 ms)

It's possible to fix them or it's normal ???

log.txt

Shad0wlife commented 8 months ago

Still not an issue, it just meand it is not from a special environment like Pumps&Hoses. I wanted to rephrase the message but forgot to add the change when pushing to github.

FirenzeIT commented 8 months ago

Yes sure, however it's works very well and never occured any issues/errors 🙂

Exist a method to not let the modhub ingame see that the mod has been modified, as it always asks for an update (obviously a method that works, without crashing/broken the mod).. One trick it's rename the mod, but works without any issues? I just tried this with others mods and when i rename them, after a while crash the game.. ​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​ [image: f8171bc3e730678481cd2fbb0cbdea2e3909219b]

Il Ven 19 Gen 2024, 06:25 Shad0wlife @.***> ha scritto:

Still not an issue, it just meand it is not from a special environment like Punps&Hoses. I wanted to rephrase the message but forgot to add the change when pushing to github.

— Reply to this email directly, view it on GitHub https://github.com/Percedal/FS22_UpgradableFactories/issues/44#issuecomment-1899791635, or unsubscribe https://github.com/notifications/unsubscribe-auth/A27M5Q3UFMZYDLN5YUT6JM3YPH7TTAVCNFSM6AAAAAA25MLXHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJZG44TCNRTGU . You are receiving this because you were mentioned.Message ID: @.***>

Shad0wlife commented 8 months ago

I can't do anything about the modhub, Percedal would need to make an actual update.

Renaming should work, but if you use the multiplayer variant i made, everyone needs to use the same zip. And also you have to make sure the "old" version of the mod is really uninstalled. Otherwise they conflict and then probably crash.

FirenzeIT commented 8 months ago

Yes sure, i know.. I only use one mod at once, not over 1 of the same mod.

Thank you. ​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​ [image: 3f9ee9d1bf9cb0a727d46823a048f2d3f1571196]

Il Ven 19 Gen 2024, 13:20 Shad0wlife @.***> ha scritto:

I can't do anything about the modhub, Percedal would need to make an actual update.

Renaming should work, but if you use the multiplayer variant i made, everyone needs to use the same zip. And also you have to make sure the "old" version of the mod is really uninstalled. Otherwise they conflict and then probably crash.

— Reply to this email directly, view it on GitHub https://github.com/Percedal/FS22_UpgradableFactories/issues/44#issuecomment-1900319021, or unsubscribe https://github.com/notifications/unsubscribe-auth/A27M5Q6TFOAWQGGXUZEHL7DYPJQKXAVCNFSM6AAAAAA25MLXHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBQGMYTSMBSGE . You are receiving this because you were mentioned.Message ID: @.***>

abbat24 commented 7 months ago

Hello! I also have a problem with the mod. I didn't get to the point of filling it with resources. I discovered that after saving and then loading the game, all purchased production levels are reset to 1 and the money is not returned. Tried disabling all the mods I use except this one and starting a new clean game without mods. Anyway, if you buy production levels, after saving they are reset to the first level. I don't know where to look...

abbat24 commented 7 months ago

I play on a very large map with a lot of production. It makes no sense to buy and install your own production facilities. But it wouldn’t be bad to make production that already exists work! And it’s generally great to increase the production speed!

Shad0wlife commented 7 months ago

Did you trybit with the version from modhub? That's been broken for ages. Use the one I last posted in this discussion or the one from the multiplayer discussion if you want to use it in MP.

abbat24 commented 7 months ago

I've tried all the options. Yours corrected, with modhub. Could there be a problem with the card? Or a pirated version of the game?

abbat24 commented 7 months ago

Now I tested the mod on other maps. It works on some maps, but on others it also resets the production level to 1.