search

Percona-Lab / mongodb_consistent_backup

A tool for performing consistent backups of MongoDB Clusters or Replica Sets
https://www.percona.com
Apache License 2.0
276 stars 81 forks source link

Explicit S3 key #224

Closed jessewiles closed 6 years ago

jessewiles commented 6 years ago

This PR adds support for explicitly specifying the S3 storage key from the command line. Using this explicit key allows a user to specify a consistent key and leverage S3's built-in versioning.

timvaillancourt commented 6 years ago

Hi @jessewiles,

Thanks for your fixes to the S3 Uploader! We will be freezing the code for the next 7 days or so to stabilise the code for the 1.2.0 release during our Percona Live Europe Conference. I'll review this code after that freeze.

Lastly, some code cleanup in recent PR seems to have created conflicts with this PR, could you resolve them? This might be the fixes I did to adhere to Python pep8/flake8 standards.

timvaillancourt commented 6 years ago

Fixed merge conflict due to changes in S3/init.py that happened after this PR.

I'll merge this if Travis-CI passes. Thanks @jessewiles!