search

Percona-Lab / mongodb_consistent_backup

A tool for performing consistent backups of MongoDB Clusters or Replica Sets
https://www.percona.com
Apache License 2.0
276 stars 81 forks source link

Fix: 'MongodumpThread' object has no attribute 'client_cert_file' #237

Closed carl-peng closed 6 years ago

carl-peng commented 6 years ago

Fix wrong ssl flag to avoid always fail in 'object has no attribute 'client_cert_file' when try connect to an MongoDB with SSL

timvaillancourt commented 6 years ago

Blocked by #238. This will fix the Travis CI failure blocking this PR

timvaillancourt commented 6 years ago

Hi @carl-peng,

Unfortunately a new flake8 code quality check is blocking your change in Travis-CI. Our build checks flake8 each build.

I've fixed this new flake8 error in #238, however this means you'll need to merge master into your branch to get this fix. Could you do that please?

This can be done in your branch's checkout with:

  1. git remote add upstream https://github.com/Percona-Lab/mongodb_consistent_backup
  2. git fetch upstream
  3. git merge upstream/master
  4. git push

Once Travis-CI passes this can be merged. Thanks!

Tim

carl-peng commented 6 years ago

hi, Tim, Sure, I'll do it. Thanks a lot for notice.

Carl

timvaillancourt commented 6 years ago

This looks good now, thanks @carl-peng!