search

Percona-Lab / pg_tde

MIT License
107 stars 19 forks source link

Add MacOS specific linker flags to meson tests build step for MacOS #100

Closed artemgavrilov closed 8 months ago

artemgavrilov commented 8 months ago

Fixes https://github.com/Percona-Lab/postgres-tde-ext/issues/25

Unlike linux on MacOS shared library and loadable module(bundle) are different things. So linker was miss -bundle flag for testing executables build.

https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/LoadingCode/Concepts/AboutLoadableBundles.html

github-actions[bot] commented 8 months ago

Performance test results: Normal queries: 9122 TDE queries: 8151 Percentage: 89%

dutow commented 8 months ago

@artemgavrilov could you also try to add a macos based github action? It can be a separate PR, but it would help with keeping the build working in the future.

artemgavrilov commented 8 months ago

@artemgavrilov could you also try to add a macos based github action? It can be a separate PR, but it would help with keeping the build working in the future.

Sure, will do it in separate PR