Percona-Lab / pg_tde

MIT License
107 stars 19 forks source link

TDE fork for relation created by the aborted transaction gets shipped to standby side #65

Closed codeforall closed 6 months ago

codeforall commented 10 months ago
BEGIN;
create table to_rollback( a int, b text) using pg_tde ;
insert into to_rollback values ( 4,'four'), (5,'five'), (6, 'six');
rollback ;

Executing this test case ships the tde fork files to standby even when the transaction was aborted.

dAdAbird commented 7 months ago

@EngineeredVirus :

Test:
(1) Explicit Transaction Block
(2) Prepared Transaction
(3) Rolling back to an earlier savepoint
Adding PITR scenarios… CREATE TABLE x. Rollback to an earlier PIT and then CREATE TABLE y. Do we end up with the same table OID for table y as table x? If we do, then, as discussed, we need to overwrite the map entry in the map file.
dAdAbird commented 7 months ago

@codeforall: check if we can rewrite map file

codeforall commented 6 months ago

We have changed the design around storing the relation keys, and the extension no longer creates the relation file. So, this issue is no longer valid.